Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix cat.health test failures in pre 1.0.0 mixed cluster test #928

Merged
merged 3 commits into from
Jul 2, 2021
Merged

[BUG] Fix cat.health test failures in pre 1.0.0 mixed cluster test #928

merged 3 commits into from
Jul 2, 2021

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jul 2, 2021 •
edited
Loading

Fixes the cat.health yaml failures when running in a bwc mixed cluster with legacy (pre 1.0.0) nodes.

closes #912
closes #922

@nknize
[BUG] Fix cat.health test failures in pre 1.0.0 mixed cluster test
b1ab42f 
Fixes the cat.health yaml failures when running in a bwc mixed cluster with
legacy (pre 1.0.0) nodes.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize added bug Something isn't working v1.0.0 Version 1.0.0 v2.0.0 Version 2.0.0 Severity-Minor labels Jul 2, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success b1ab42f

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed b1ab42f

@nknize
fix skip version to 7.10.*
bb41c35 
Signed-off-by: Nicholas Walter Knize <[email protected]>
@adnapibar
Copy link
Contributor

start gradle check

@nknize nknize requested a review from adnapibar July 2, 2021 18:23
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success bb41c35

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed bb41c35

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success b1ab42f

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success bb41c35

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure bb41c35
Log 303

Reports 303

@adnapibar
Copy link
Contributor

start gradle check

@nknize
Copy link
Collaborator Author

nknize commented Jul 2, 2021

Reproducible failure:

2> REPRODUCE WITH: ./gradlew ':test:framework:test' --tests "org.opensearch.transport.nio.SimpleMockNioTransportTests.testHandshakeUpdatesVersion" -Dtests.seed=902A0F9695E867C7 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1" -Dtests.locale=zh-CN -Dtests.timezone=Pacific/Saipan -Druntime.java=15
  2> java.lang.AssertionError: expected:<7.10.2> but was:<1.1.0>

@nknize
Copy link
Collaborator Author

nknize commented Jul 2, 2021 •
edited
Loading

Working the fix. Note: this is unrelated to the original failure fixed by this PR.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success bb41c35
Log 304

Reports 304

adnapibar
adnapibar approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@nknize
fix transport handshake failure
e235dbe 
Signed-off-by: Nicholas Walter Knize <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed e235dbe

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success e235dbe

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success e235dbe

@adnapibar
Copy link
Contributor

start gradle check

@nknize nknize mentioned this pull request Jul 2, 2021
Closed
@tlfeng tlfeng mentioned this pull request Jul 2, 2021
Merged
5 tasks
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure e235dbe
Log 308

Reports 308

@tlfeng
Copy link
Collaborator

tlfeng commented Jul 2, 2021

Test failure in Log 308:

> Task :server:internalClusterTest

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.ConcurrentSnapshotsIT.testConcurrentOperationsLimit" -Dtests.seed=6D5FF829B1A6829A -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1" -Dtests.locale=ar-SA -Dtests.timezone=Asia/Bangkok -Druntime.java=15

org.opensearch.snapshots.ConcurrentSnapshotsIT > testConcurrentOperationsLimit FAILED
    java.lang.Exception: Test abandoned because suite timeout was reached.
        at __randomizedtesting.SeedInfo.seed([6D5FF829B1A6829A]:0)

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.ConcurrentSnapshotsIT.testConcurrentOperationsLimit" -Dtests.seed=6D5FF829B1A6829A -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1" -Dtests.locale=ar-SA -Dtests.timezone=Asia/Bangkok -Druntime.java=15

org.opensearch.snapshots.ConcurrentSnapshotsIT > classMethod FAILED
    java.lang.Exception: Suite timeout exceeded (>= 1200000 msec).
        at __randomizedtesting.SeedInfo.seed([6D5FF829B1A6829A]:0)

@nknize
Copy link
Collaborator Author

nknize commented Jul 2, 2021

This isn't reproducible. Looks like a CI machine issue?

@nknize
Copy link
Collaborator Author

nknize commented Jul 2, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success e235dbe
Log 312

Reports 312

@nknize nknize merged this pull request into opensearch-project:main Jul 2, 2021
nknize added a commit that referenced this pull request Jul 2, 2021
@nknize
[BUG] Fix cat.health test failures in pre 1.0.0 mixed cluster test (#928
2d1a1e6 
)

Fixes the cat.health yaml failures when running in a bwc mixed cluster with
legacy (pre 1.0.0) nodes.

Signed-off-by: Nicholas Walter Knize <[email protected]>
nknize added a commit to nknize/OpenSearch that referenced this pull request Jul 2, 2021
@nknize
[BUG] Fix cat.health test failures in pre 1.0.0 mixed cluster test (o…
81dbbfb 
…pensearch-project#928)

Fixes the cat.health yaml failures when running in a bwc mixed cluster with
legacy (pre 1.0.0) nodes.

Signed-off-by: Nicholas Walter Knize <[email protected]>
nknize added a commit that referenced this pull request Jul 2, 2021
@nknize
[BUG] Fix cat.health test failures in pre 1.0.0 mixed cluster test (#928
da6455d 
) (#935)

Fixes the cat.health yaml failures when running in a bwc mixed cluster with
legacy (pre 1.0.0) nodes.

Signed-off-by: Nicholas Walter Knize <[email protected]>
nknize added a commit that referenced this pull request Jul 2, 2021
@nknize
[BUG] Fix cat.health test failures in pre 1.0.0 mixed cluster test (#928
34550c5 
) (#935)

Fixes the cat.health yaml failures when running in a bwc mixed cluster with
legacy (pre 1.0.0) nodes.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@vrozov vrozov mentioned this pull request Jul 14, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnapibar adnapibar adnapibar approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Severity-Minor v1.0.0 Version 1.0.0 v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
4 participants
@nknize @opensearch-ci-bot @adnapibar @tlfeng