Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for query profiler with concurrent aggregation #9248

Merged
merged 9 commits into from
Sep 5, 2023
Merged

Add support for query profiler with concurrent aggregation #9248

merged 9 commits into from
Sep 5, 2023

Commits on Sep 5, 2023

  1. Add support for query profiler with concurrent aggregation (opensearc… 

    …h-project#9248)

Signed-off-by: Ticheng Lin <[email protected]>
    @ticheng-aws
    ticheng-aws committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    e6ad355 View commit details
    Browse the repository at this point in the history

  2. Refactor and work on the PR comments 

    Signed-off-by: Ticheng Lin <[email protected]>
    @ticheng-aws
    ticheng-aws committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a6cee80 View commit details
    Browse the repository at this point in the history

  3. Update collectorToLeaves mapping for children breakdowns post profile… 

    … metric collection and before creating the results

Signed-off-by: Sorabh Hamirwasia <[email protected]>
    @sohami @ticheng-aws
    sohami authored and ticheng-aws committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    adc9b51 View commit details
    Browse the repository at this point in the history

  4. Refactor logic to compute the slice level breakdown stats and query l… 

    …evel breakdown stats for concurrent search case

Signed-off-by: Sorabh Hamirwasia <[email protected]>
    @sohami @ticheng-aws
    sohami authored and ticheng-aws committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    0868b20 View commit details
    Browse the repository at this point in the history

  5. Fix QueryProfilePhaseTests and QueryProfileTests, and parameterize Qu… 

    …eryProfilerIT with concurrent search enabled

Signed-off-by: Ticheng Lin <[email protected]>
    @ticheng-aws
    ticheng-aws committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b5af44e View commit details
    Browse the repository at this point in the history

  6. Handle the case when there are no leaf context to compute the profile… 

    … stats to return default stats

for all breakdown type along with min/max/avg values. Replace queryStart and queryEnd time with queryNodeTime

Signed-off-by: Sorabh Hamirwasia <[email protected]>
    @sohami @ticheng-aws
    sohami authored and ticheng-aws committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c9fcca0 View commit details
    Browse the repository at this point in the history

  7. Add UTs for ConcurrentQueryProfileBreakdown 

    Signed-off-by: Sorabh Hamirwasia <[email protected]>
    @sohami @ticheng-aws
    sohami authored and ticheng-aws committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    34b048e View commit details
    Browse the repository at this point in the history

  8. Add concurrent search stats test into the QueryProfilerIT 

    Signed-off-by: Ticheng Lin <[email protected]>
    @ticheng-aws
    ticheng-aws committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    ae1af62 View commit details
    Browse the repository at this point in the history

  9. Address review comments 

    Signed-off-by: Sorabh Hamirwasia <[email protected]>
    @sohami @ticheng-aws
    sohami authored and ticheng-aws committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    6644e02 View commit details
    Browse the repository at this point in the history