Fix compilation warning in CollectionUtils affecting maven snapshot publication

[cwperks]

Description

Maven snapshot publication started failing after: #9120

The error stemmed from a compilation warning:

/home/runner/work/OpenSearch/OpenSearch/libs/core/src/main/java/org/opensearch/core/common/util/CollectionUtils.java:143: warning: [unchecked] unchecked generic array creation for varargs parameter of type Iterator<? extends Object>[]
return () -> Iterators.concat(map.keySet().iterator(), map.values().iterator());
^
error: warnings found and -Werror specified

See: https://github.com/opensearch-project/OpenSearch/actions/runs/5767554873/job/15637408847

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[cwperks]

@nknize @reta Can I get a review on this? The maven snapshots stopped publishing after a change in CollectionUtils due to a compiler warning.

[peternied]

Lets get this unblocked by merging,

• Can we get a follow up issue to make sure warnings as errors is on by default in the build

[nknize]

• Can we get a follow up issue to make sure warnings as errors is on by default in the build

💯 agree. I noticed this failed on 2.x but not main. That has a bad smell to it, as if the build configs are different. But we should be pushing to main and backporting so I'm not sure why main didn't fail w/o the suppress warning but 2.x did fail?

[opensearch-trigger-bot]

Compatibility status:

> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 23m 46s

[cwperks]

@peternied @nknize I filed an issue to investigate why the build on main did not catch this initially and see why there is a discrepancy between main and 2.x: #9150

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/22025/
• CommitID: 4ec3ab3
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[opensearch-trigger-bot]

Compatibility status:

> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 30m 46s

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/22029/
• CommitID: d3a0780

[codecov]

Codecov Report

Merging #9149 (d3a0780) into main (bb78930) will decrease coverage by 0.07%.
Report is 4 commits behind head on main.
The diff coverage is 72.04%.

@@             Coverage Diff              @@
##               main    #9149      +/-   ##
============================================
- Coverage     71.06%   70.99%   -0.07%     
+ Complexity    57314    57280      -34     
============================================
  Files          4766     4765       -1     
  Lines        270453   270479      +26     
  Branches      39555    39553       -2     
============================================
- Hits         192197   192040     -157     
- Misses        62045    62256     +211     
+ Partials      16211    16183      -28     

Files Changed	Coverage Δ
.../opensearch/client/indices/CreateIndexRequest.java	77.77% <0.00%> (+1.11%)	⬆️
...opensearch/client/slm/SnapshotLifecyclePolicy.java	0.00% <ø> (ø)
...ch/client/slm/SnapshotLifecyclePolicyMetadata.java	0.00% <ø> (ø)
.../opensearch/client/slm/SnapshotLifecycleStats.java	0.00% <ø> (ø)
...rch/client/slm/SnapshotRetentionConfiguration.java	0.00% <ø> (ø)
...g/opensearch/core/common/util/CollectionUtils.java	77.06% <ø> (ø)
...h/script/mustache/MultiSearchTemplateResponse.java	59.01% <ø> (ø)
...rg/opensearch/index/rankeval/RankEvalResponse.java	97.14% <ø> (+7.14%)	⬆️
...va/org/opensearch/index/rankeval/RankEvalSpec.java	97.36% <ø> (ø)
...a/org/opensearch/index/rankeval/RatedDocument.java	81.03% <0.00%> (ø)
... and 135 more

... and 434 files with indirect coverage changes