Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove searchSegmentOrderReversed from IndexSettings #8808

Merged

Conversation

andrross
Copy link
Member

This property is unused now and can be safely removed.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

* **RESULT:**  ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/20630/

* **CommitID:** [879a29b](https://github.com/opensearch-project/OpenSearch/commit/879a29bff06c720ed6a712ee4cf4d8fccda21829)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

The build actually succeeded here. It seems like there was a brief outage of the Jenkins API server that caused the github action to fail while checking the status.

This property is unused now and can be safely removed.

Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross force-pushed the unused-index-settings-method branch from 879a29b to 3f34bb6 Compare July 21, 2023 16:06
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocationWithSegRepFailure

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #8808 (3f34bb6) into main (3adde3a) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8808      +/-   ##
============================================
- Coverage     70.95%   70.85%   -0.10%     
+ Complexity    57202    57164      -38     
============================================
  Files          4771     4771              
  Lines        270271   270268       -3     
  Branches      39506    39506              
============================================
- Hits         191776   191508     -268     
- Misses        62336    62615     +279     
+ Partials      16159    16145      -14     
Impacted Files Coverage Δ
.../main/java/org/opensearch/index/IndexSettings.java 85.75% <ø> (+0.64%) ⬆️

... and 448 files with indirect coverage changes

@andrross andrross merged commit db838c4 into opensearch-project:main Jul 21, 2023
@andrross andrross deleted the unused-index-settings-method branch July 21, 2023 21:15
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 21, 2023
This property is unused now and can be safely removed.

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit db838c4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Jul 21, 2023
This property is unused now and can be safely removed.


(cherry picked from commit db838c4)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…ect#8808)

This property is unused now and can be safely removed.

Signed-off-by: Andrew Ross <[email protected]>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…ect#8808)

This property is unused now and can be safely removed.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…ect#8808)

This property is unused now and can be safely removed.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Ivan Brusic <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ect#8808)

This property is unused now and can be safely removed.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants