-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove searchSegmentOrderReversed from IndexSettings #8808
Merged
andrross
merged 1 commit into
opensearch-project:main
from
andrross:unused-index-settings-method
Jul 21, 2023
Merged
Remove searchSegmentOrderReversed from IndexSettings #8808
andrross
merged 1 commit into
opensearch-project:main
from
andrross:unused-index-settings-method
Jul 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrross
requested review from
reta,
anasalkouz,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
July 20, 2023 23:16
Gradle Check (Jenkins) Run Completed with:
|
The build actually succeeded here. It seems like there was a brief outage of the Jenkins API server that caused the github action to fail while checking the status. |
This property is unused now and can be safely removed. Signed-off-by: Andrew Ross <[email protected]>
andrross
force-pushed
the
unused-index-settings-method
branch
from
July 21, 2023 16:06
879a29b
to
3f34bb6
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8808 +/- ##
============================================
- Coverage 70.95% 70.85% -0.10%
+ Complexity 57202 57164 -38
============================================
Files 4771 4771
Lines 270271 270268 -3
Branches 39506 39506
============================================
- Hits 191776 191508 -268
- Misses 62336 62615 +279
+ Partials 16159 16145 -14
|
kotwanikunal
approved these changes
Jul 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
This property is unused now and can be safely removed. Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit db838c4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal
pushed a commit
that referenced
this pull request
Jul 21, 2023
This property is unused now and can be safely removed. (cherry picked from commit db838c4) Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 29, 2023
…ect#8808) This property is unused now and can be safely removed. Signed-off-by: Andrew Ross <[email protected]>
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
…ect#8808) This property is unused now and can be safely removed. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
…ect#8808) This property is unused now and can be safely removed. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…ect#8808) This property is unused now and can be safely removed. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property is unused now and can be safely removed.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.