Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of crypto plugin #8465

Merged
merged 8 commits into from
Sep 5, 2023

Conversation

vikasvb90
Copy link
Contributor

@vikasvb90 vikasvb90 commented Jul 6, 2023

Description

Crypto kms plugin to to provide AWS KMS based key providers used in encryption/decryption.
Design doc : #6633

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT:
  • URL:
  • CommitID: 1ecf720
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT:
  • URL:
  • CommitID: 2790713
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

Signed-off-by: Vikas Bansal <[email protected]>

Removed encrypted flag from repo metadata and moved crypto invocations to happen via CryptoProvider

Signed-off-by: Vikas Bansal <[email protected]>

Structural changes to move crypto cache and crypto manager to libs and added settings for crypto kms plugin

Signed-off-by: Vikas Bansal <[email protected]>

Immutable map for crypto manager factory

Signed-off-by: Vikas Bansal <[email protected]>
Signed-off-by: Vikas Bansal <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Compatibility status:

Checks if related components are compatible with change 485fc1b

Incompatible components

Incompatible components: [https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #8465 (485fc1b) into main (63ce832) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 61.96%.

@@            Coverage Diff             @@
##               main    #8465    +/-   ##
==========================================
  Coverage     71.07%   71.08%            
- Complexity    57814    57900    +86     
==========================================
  Files          4815     4822     +7     
  Lines        272709   272964   +255     
  Branches      39792    39822    +30     
==========================================
+ Hits         193839   194035   +196     
- Misses        62622    62625     +3     
- Partials      16248    16304    +56     
Files Changed Coverage Δ
...rg/opensearch/crypto/kms/KmsMasterKeyProvider.java 0.00% <0.00%> (ø)
...ensearch/crypto/kms/CredentialProviderFactory.java 23.07% <23.07%> (ø)
...ain/java/org/opensearch/crypto/kms/KmsService.java 59.59% <59.59%> (ø)
...ava/org/opensearch/crypto/kms/CryptoKmsPlugin.java 70.58% <70.58%> (ø)
...a/org/opensearch/crypto/kms/KmsClientSettings.java 78.94% <78.94%> (ø)
...pensearch/crypto/kms/AmazonKmsClientReference.java 100.00% <100.00%> (ø)
...n/java/org/opensearch/crypto/kms/SocketAccess.java 100.00% <100.00%> (ø)

... and 449 files with indirect coverage changes

@gbbafna gbbafna merged commit 7c8effb into opensearch-project:main Sep 5, 2023
11 of 12 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Sep 5, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-8465-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7c8effb0cee3f12344f1100c7f17e672a8e999dc
# Push it to GitHub
git push --set-upstream origin backport/backport-8465-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8465-to-2.x.

vikasvb90 added a commit to vikasvb90/OpenSearch that referenced this pull request Sep 5, 2023
Signed-off-by: Vikas Bansal <[email protected]>
(cherry picked from commit 7c8effb)
vikasvb90 added a commit to vikasvb90/OpenSearch that referenced this pull request Sep 5, 2023
Signed-off-by: Vikas Bansal <[email protected]>
(cherry picked from commit 7c8effb)
Signed-off-by: Vikas Bansal <[email protected]>
vikasvb90 added a commit to vikasvb90/OpenSearch that referenced this pull request Sep 5, 2023
Signed-off-by: Vikas Bansal <[email protected]>
(cherry picked from commit 7c8effb)
vikasvb90 added a commit to vikasvb90/OpenSearch that referenced this pull request Sep 5, 2023
Signed-off-by: Vikas Bansal <[email protected]>
(cherry picked from commit 7c8effb)
vikasvb90 added a commit to vikasvb90/OpenSearch that referenced this pull request Sep 5, 2023
Signed-off-by: Vikas Bansal <[email protected]>
(cherry picked from commit 7c8effb)
vikasvb90 added a commit to vikasvb90/OpenSearch that referenced this pull request Sep 5, 2023
Signed-off-by: Vikas Bansal <[email protected]>
(cherry picked from commit 7c8effb)
gbbafna pushed a commit that referenced this pull request Sep 5, 2023
Signed-off-by: Vikas Bansal <[email protected]>
(cherry picked from commit 7c8effb)
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed feature New feature or request Storage:Durability Issues and PRs related to the durability framework v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants