Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Refactor] OpenSearchException and ExceptionsHelper foundation to base class (#7508) #8460

Merged
merged 1 commit into from
Jul 6, 2023
Merged

[Backport 2.x] [Refactor] OpenSearchException and ExceptionsHelper foundation to base class (#7508) #8460

merged 1 commit into from
Jul 6, 2023

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jul 6, 2023

Backport 1e08b5a from #7508.

@nknize
[Refactor] OpenSearchException and ExceptionsHelper foundation to bas…
3d6b296 
…e class (opensearch-project#7508)

Creates new BaseOpenSearchException and BaseExceptionsHelper in core
library as a step to moving OpenSearch exception mechanisms from the
server module to core library. This is a move to support serverless and
cloud native capabilities without requiring the server module for core
opensearch indexing, search, and compute capabilities.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments v2.9.0 'Issues and PRs related to version v2.9.0' labels Jul 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testCancelPrimaryAllocation

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #8460 (3d6b296) into 2.x (c56d165) will decrease coverage by 0.10%.
The diff coverage is 74.07%.

@@             Coverage Diff              @@
##                2.x    #8460      +/-   ##
============================================
- Coverage     70.61%   70.52%   -0.10%     
+ Complexity    57074    57027      -47     
============================================
  Files          4743     4746       +3     
  Lines        270436   270449      +13     
  Branches      39931    39931              
============================================
- Hits         190974   190729     -245     
- Misses        63041    63335     +294     
+ Partials      16421    16385      -36
Impacted Files Coverage Δ
...rg/opensearch/client/ClusterRequestConverters.java 44.28% <ø> (ø)
...rg/opensearch/client/IndicesRequestConverters.java 71.03% <ø> (+0.27%) ⬆️
.../java/org/opensearch/client/RequestConverters.java 84.35% <ø> (+0.16%) ⬆️
...g/opensearch/client/SnapshotRequestConverters.java 79.31% <ø> (+0.86%) ⬆️
.../java/org/opensearch/client/core/CountRequest.java 68.42% <ø> (-2.64%) ⬇️
.../org/opensearch/client/indices/AnalyzeRequest.java 76.00% <ø> (ø)
...client/indices/ComponentTemplatesExistRequest.java 0.00% <ø> (ø)
...t/indices/ComposableIndexTemplateExistRequest.java 0.00% <ø> (ø)
...ensearch/client/indices/DetailAnalyzeResponse.java 54.79% <ø> (ø)
...search/client/indices/GetFieldMappingsRequest.java 57.14% <ø> (-19.05%) ⬇️
... and 234 more

... and 434 files with indirect coverage changes

@reta reta merged commit 68a4d36 into opensearch-project:2.x Jul 6, 2023
@parasjain1 parasjain1 mentioned this pull request Jul 7, 2023
Closed
2 tasks
@cwperks cwperks mentioned this pull request Jul 7, 2023
Closed
@derek-ho derek-ho mentioned this pull request Jul 13, 2023
Merged
6 tasks
@prudhvigodithi prudhvigodithi mentioned this pull request Jul 13, 2023
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments enhancement Enhancement or improvement to existing feature or request v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nknize @reta