-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Search Pipelines] Add stats for search pipelines #8376
[Backport 2.x] [Search Pipelines] Add stats for search pipelines #8376
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
a74d58d
to
209a00a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Need help in rerunning gradle check |
It looks like the Gradle check is failing because of the 1.3.11 release -- the buildBwcLinuxTar target is now building 1.3.12? |
Note that to avoid breaking backward compatibility tests on See #8070 for discussion. |
server/src/main/java/org/opensearch/action/admin/cluster/node/stats/NodeStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/action/admin/cluster/node/stats/NodeStats.java
Outdated
Show resolved
Hide resolved
created #8416 to update the version checks on |
…#8053) * [Search Pipelines] Add stats for search pipelines This adds statistics on executions and time spent on search pipeline operations, similar to the stats that are available for ingest pipelines. Signed-off-by: Michael Froh <[email protected]> * Compare parsed JSON structure, not exact JSON string As @lukas-vlcek pointed out, asserting equality with an exact JSON string is sensitive to formatting, which makes the test brittle. Instead, we can parse the expected JSON and compare as Maps. Signed-off-by: Michael Froh <[email protected]> * Refactor to common stats/metrics classes Search pipelines and ingest pipelines had identical functionality for tracking metrics around operations and converting those to immutable "stats" objects. That approach isn't even really specific to pipelines, but can be used to track metrics on any repeated operation, so I moved that common logic to the common.metrics package. Signed-off-by: Michael Froh <[email protected]> * Split pipeline metrics tracking into its own class Thanks @saratvemulapalli for the suggestion! This lets the Pipeline class focus on transforming requests / responses, while the subclass focuses on tracking and managing metrics. Signed-off-by: Michael Froh <[email protected]> --------- Signed-off-by: Michael Froh <[email protected]> (cherry picked from commit 46c9a21)
Signed-off-by: Mingshi Liu <[email protected]>
209a00a
to
0d648c8
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #8376 +/- ##
============================================
+ Coverage 70.47% 70.52% +0.04%
- Complexity 56953 57039 +86
============================================
Files 4737 4740 +3
Lines 270103 270416 +313
Branches 39905 39940 +35
============================================
+ Hits 190345 190699 +354
+ Misses 63404 63348 -56
- Partials 16354 16369 +15
|
Signed-off-by: Mingshi Liu <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Thank you @tlfeng ! |
Description
manual back-porting #8053 and resolve conflict
Related Issues
Resolves #6723
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.