Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions] Change extension integration testing to reflect new initialization sequence #8145

Conversation

ryanbogan
Copy link
Member

Description

Initial changes to ensure integration testing for extensions functions properly, following #8029

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testBasicTaskResourceTracking

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #8145 (b6c669d) into main (b5b0042) will increase coverage by 0.56%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #8145      +/-   ##
============================================
+ Coverage     70.86%   71.42%   +0.56%     
- Complexity    56636    57017     +381     
============================================
  Files          4722     4722              
  Lines        267608   267588      -20     
  Branches      39216    39213       -3     
============================================
+ Hits         189647   191138    +1491     
+ Misses        61922    60635    -1287     
+ Partials      16039    15815     -224     
Impacted Files Coverage Δ
...nsearch/gradle/testclusters/OpenSearchCluster.java 0.00% <0.00%> (ø)
...opensearch/gradle/testclusters/OpenSearchNode.java 0.00% <0.00%> (ø)
.../gradle/testclusters/TestClusterConfiguration.java 0.00% <ø> (ø)

... and 429 files with indirect coverage changes

@saratvemulapalli saratvemulapalli added the backport 2.x Backport to 2.x branch label Jul 7, 2023
@saratvemulapalli saratvemulapalli merged commit 52a5e3f into opensearch-project:main Jul 7, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8145-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 52a5e3f6e0ca599e3193807134ea42660ecdd195
# Push it to GitHub
git push --set-upstream origin backport/backport-8145-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8145-to-2.x.

DarshitChanpura pushed a commit to DarshitChanpura/OpenSearch that referenced this pull request Jul 10, 2023
DarshitChanpura pushed a commit to DarshitChanpura/OpenSearch that referenced this pull request Jul 10, 2023
…quence (opensearch-project#8145)

Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit 52a5e3f)
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura added a commit to DarshitChanpura/OpenSearch that referenced this pull request Jul 10, 2023
…quence (opensearch-project#8145)

Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit 52a5e3f)
Signed-off-by: Darshit Chanpura <[email protected]>
saratvemulapalli pushed a commit that referenced this pull request Jul 10, 2023
…quence (#8145) (#8588)

(cherry picked from commit 52a5e3f)

Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants