-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] [2.x] [Concurrent Segment Search]: Add new query profile collector fields with concurrent search execution (#7898) #7975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on (opensearch-project#7898) * Bringing new query profile collector fields with concurrent search execution Signed-off-by: Ticheng Lin <[email protected]> * Update CHANGELOG.md and fix gradle check format violations Signed-off-by: Ticheng Lin <[email protected]> * Change query profile collector field data types to primitives and add more tests Signed-off-by: Ticheng Lin <[email protected]> --------- Signed-off-by: Ticheng Lin <[email protected]> Signed-off-by: Ticheng Lin <[email protected]> (cherry picked from commit c58dc1a) Signed-off-by: Ticheng Lin <[email protected]>
ticheng-aws
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
dbwiddis
as code owners
June 8, 2023 18:15
Gradle Check (Jenkins) Run Completed with:
|
reta
requested changes
Jun 8, 2023
server/src/main/java/org/opensearch/search/profile/query/CollectorResult.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/search/profile/query/CollectorResult.java
Outdated
Show resolved
Hide resolved
…ctorResult.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Ticheng Lin <[email protected]>
reta
approved these changes
Jun 8, 2023
Gradle Check (Jenkins) Run Completed with:
|
6 tasks
Gradle Check (Jenkins) Run Completed with:
|
ticheng-aws
force-pushed
the
backport-7898-to-2.x
branch
from
June 8, 2023 22:06
f9a1dd6
to
52fd08e
Compare
Gradle Check (Jenkins) Run Completed with:
|
ticheng-aws
force-pushed
the
backport-7898-to-2.x
branch
from
June 8, 2023 22:50
52fd08e
to
fa83dc5
Compare
Gradle Check (Jenkins) Run Completed with:
|
reta
reviewed
Jun 8, 2023
server/src/main/java/org/opensearch/search/profile/query/CollectorResult.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## 2.x #7975 +/- ##
============================================
+ Coverage 70.61% 70.75% +0.13%
- Complexity 56566 56649 +83
============================================
Files 4681 4681
Lines 268060 268158 +98
Branches 39656 39668 +12
============================================
+ Hits 189301 189737 +436
+ Misses 62438 62084 -354
- Partials 16321 16337 +16
|
6 tasks
ticheng-aws
force-pushed
the
backport-7898-to-2.x
branch
from
June 9, 2023 00:15
fa83dc5
to
be44fd5
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
…ctorResult.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Ticheng Lin <[email protected]>
ticheng-aws
force-pushed
the
backport-7898-to-2.x
branch
from
June 9, 2023 02:48
be44fd5
to
0f59e8b
Compare
Gradle Check (Jenkins) Run Completed with:
|
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…ollector fields with concurrent search execution (opensearch-project#7898) (opensearch-project#7975) * Add new query profile collector fields with concurrent search execution (opensearch-project#7898) * Bringing new query profile collector fields with concurrent search execution Signed-off-by: Ticheng Lin <[email protected]> * Update CHANGELOG.md and fix gradle check format violations Signed-off-by: Ticheng Lin <[email protected]> * Change query profile collector field data types to primitives and add more tests Signed-off-by: Ticheng Lin <[email protected]> --------- Signed-off-by: Ticheng Lin <[email protected]> Signed-off-by: Ticheng Lin <[email protected]> (cherry picked from commit c58dc1a) Signed-off-by: Ticheng Lin <[email protected]> * Update server/src/main/java/org/opensearch/search/profile/query/CollectorResult.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Ticheng Lin <[email protected]> * Update server/src/main/java/org/opensearch/search/profile/query/CollectorResult.java Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Ticheng Lin <[email protected]> --------- Signed-off-by: Ticheng Lin <[email protected]> Signed-off-by: Ticheng Lin <[email protected]> Co-authored-by: Andriy Redko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit c58dc1a)
Description
Backport of #7898 to
2.x
branch.To show high-level concurrent execution details, we bring
min_slice_time_in_nanos
,max_slice_time_in_nanos
, andslice_count
etc. fields into the query response. With these new fields, users can quickly determine query performance and skew issues.Definition of existing collector fields
name
: A more friendly representation of the collector's class name.reason
: A "hint" to help provide some context about this collector.time_in_nanos
: The total elapsed time for this collector. In the concurrent search case, this is the total time across all slices (i.e.max(slice_end_time) - min(slice_start_time)
)children
: A list of children collectors "embedded" inside this collector.Definition of new collector fields with concurrent execution
reduce_time_in_nanos
: The elapsed time in the reduce phase.min_slice_time_in_nanos
: The minimum slice time for this collector manager.max_slice_time_in_nanos
: The maximum slice time for this collector manager.avg_slice_time_in_nanos
: The average slice time for this collector manager.slice_count
: The segment slice count for this collector manager.Related Issues
Resolves #7355
Doc update issue: opensearch-project/documentation-website#4281
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.