-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support transport action names when registering NamedRoutes #7957
Support transport action names when registering NamedRoutes #7957
Conversation
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DarshitChanpura, I left some minor comments but otherwise this looks good to me.
server/src/test/java/org/opensearch/action/DynamicActionRegistryTests.java
Show resolved
Hide resolved
Signed-off-by: Darshit Chanpura <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
21903da
to
8773509
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Darshit Chanpura <[email protected]>
bff1a58
to
411c12a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Darshit Chanpura <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/rest/extensions/RestSendToExtensionAction.java
Outdated
Show resolved
Hide resolved
…ring a named route Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Darshit Chanpura <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Darshit Chanpura <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just two final requests.
Signed-off-by: Darshit Chanpura <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work.
Gradle Check (Jenkins) Run Completed with:
|
@peternied Would you please merge this? |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7957-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 50d8006d5ffb72566b893ef23748d48b26c3a65e
# Push it to GitHub
git push --set-upstream origin backport/backport-7957-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…ch-project#7957) * Adds ability to register legacy action names along with route Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 50d8006)
…outes (#7957) (#8459) * Support transport action names when registering NamedRoutes (#7957) * Adds ability to register legacy action names along with route Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit 50d8006) * Fixes Changelog entry Signed-off-by: Darshit Chanpura <[email protected]> --------- Signed-off-by: Darshit Chanpura <[email protected]>
…g NamedRoutes (opensearch-project#7957) (opensearch-project#8459)" This reverts commit cd82f4c.
…g NamedRoutes (opensearch-project#7957) (opensearch-project#8459)" This reverts commit cd82f4c. Signed-off-by: Darshit Chanpura <[email protected]>
…g NamedRoutes (opensearch-project#7957) (opensearch-project#8459)" This reverts commit cd82f4c.
…g NamedRoutes (opensearch-project#7957) (opensearch-project#8459)" This reverts commit cd82f4c. Signed-off-by: Darshit Chanpura <[email protected]>
…ch-project#7957) * Adds ability to register legacy action names along with route Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]>
…ch-project#7957) * Adds ability to register legacy action names along with route Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]>
…g NamedRoutes (#7957) (#8459)" (#8651) This reverts commit cd82f4c. Signed-off-by: Darshit Chanpura <[email protected]>
…ch-project#7957) * Adds ability to register legacy action names along with route Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: sahil buddharaju <[email protected]>
…ch-project#7957) * Adds ability to register legacy action names along with route Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]>
…ch-project#7957) * Adds ability to register legacy action names along with route Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This change allows plugin devs to register a named route to be mapped against existing transport action name by passing a legacy name when registering a NamedRoute.
Related to: opensearch-project/security#2752
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.