-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving zstd out of sandbox #7908
Moving zstd out of sandbox #7908
Conversation
5d7c2a6
to
0c302a7
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
0c302a7
to
5385ecf
Compare
Gradle Check (Jenkins) Run Completed with:
|
5385ecf
to
d330490
Compare
Gradle Check (Jenkins) Run Completed with:
|
d330490
to
fb50270
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
3fa0406
to
2e62f1b
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
2e62f1b
to
786ff0f
Compare
Gradle Check (Jenkins) Run Completed with:
|
786ff0f
to
3f86d85
Compare
Gradle Check (Jenkins) Run Completed with:
|
3f86d85
to
919eb9d
Compare
Gradle Check (Jenkins) Run Completed with:
|
919eb9d
to
7d3c2c2
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Sarthak Aggarwal <[email protected]>
e139668
to
5fd583f
Compare
Gradle Check (Jenkins) Run Completed with:
|
server/src/internalClusterTest/java/org/opensearch/index/codec/MultiCodecMergeIT.java
Show resolved
Hide resolved
Signed-off-by: Sarthak Aggarwal <[email protected]>
5fd583f
to
097efd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks @sarthakaggarwal97.
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, let's merge on green.
Gradle Check (Jenkins) Run Completed with:
|
@reta you good with this? hit merge |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7908-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 976048d5d630b7adc53f54f2b27558d3a38b1f65
# Push it to GitHub
git push --set-upstream origin backport/backport-7908-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
@sarthakaggarwal97 needs manual backport to |
thanks folks for the reviews! |
* Adding zstd module to source Signed-off-by: Sarthak Aggarwal <[email protected]> * Removing zstd module from sandbox Signed-off-by: Sarthak Aggarwal <[email protected]> * Added tests and refactoring Signed-off-by: Sarthak Aggarwal <[email protected]> * Fixing gradle issues Signed-off-by: Sarthak Aggarwal <[email protected]> * flaky test Signed-off-by: Sarthak Aggarwal <[email protected]> * fixing precommit failure Signed-off-by: Sarthak Aggarwal <[email protected]> * Incorporate review comments and fixed precommit failures Signed-off-by: Sarthak Aggarwal <[email protected]> * Incorporating review comments Signed-off-by: Sarthak Aggarwal <[email protected]> * Incorporating review comments Signed-off-by: Sarthak Aggarwal <[email protected]> * Adding Integ tests Signed-off-by: Sarthak Aggarwal <[email protected]> * Incorporating review comments Signed-off-by: Sarthak Aggarwal <[email protected]> --------- Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> (cherry picked from commit 976048d)
* Adding zstd module to source Signed-off-by: Sarthak Aggarwal <[email protected]> * Removing zstd module from sandbox Signed-off-by: Sarthak Aggarwal <[email protected]> * Added tests and refactoring Signed-off-by: Sarthak Aggarwal <[email protected]> * Fixing gradle issues Signed-off-by: Sarthak Aggarwal <[email protected]> * flaky test Signed-off-by: Sarthak Aggarwal <[email protected]> * fixing precommit failure Signed-off-by: Sarthak Aggarwal <[email protected]> * Incorporate review comments and fixed precommit failures Signed-off-by: Sarthak Aggarwal <[email protected]> * Incorporating review comments Signed-off-by: Sarthak Aggarwal <[email protected]> * Incorporating review comments Signed-off-by: Sarthak Aggarwal <[email protected]> * Adding Integ tests Signed-off-by: Sarthak Aggarwal <[email protected]> * Incorporating review comments Signed-off-by: Sarthak Aggarwal <[email protected]> --------- Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
* Adding zstd module to source Signed-off-by: Sarthak Aggarwal <[email protected]> * Removing zstd module from sandbox Signed-off-by: Sarthak Aggarwal <[email protected]> * Added tests and refactoring Signed-off-by: Sarthak Aggarwal <[email protected]> * Fixing gradle issues Signed-off-by: Sarthak Aggarwal <[email protected]> * flaky test Signed-off-by: Sarthak Aggarwal <[email protected]> * fixing precommit failure Signed-off-by: Sarthak Aggarwal <[email protected]> * Incorporate review comments and fixed precommit failures Signed-off-by: Sarthak Aggarwal <[email protected]> * Incorporating review comments Signed-off-by: Sarthak Aggarwal <[email protected]> * Incorporating review comments Signed-off-by: Sarthak Aggarwal <[email protected]> * Adding Integ tests Signed-off-by: Sarthak Aggarwal <[email protected]> * Incorporating review comments Signed-off-by: Sarthak Aggarwal <[email protected]> --------- Signed-off-by: Sarthak Aggarwal <[email protected]> Signed-off-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This PR entails the changes related to moving zstd codec from sandbox to core. The users will be able to set two new codecs zstd and zstd_no_dict upon creating an index.
Related Issues
Resolves #7805
Tested Scenarios
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.