-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove COMPRESSOR variable from CompressorFactory #7907
Remove COMPRESSOR variable from CompressorFactory #7907
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7907 +/- ##
============================================
+ Coverage 70.87% 70.99% +0.12%
- Complexity 56504 56631 +127
============================================
Files 4719 4719
Lines 267408 267409 +1
Branches 39196 39196
============================================
+ Hits 189521 189847 +326
+ Misses 61861 61551 -310
+ Partials 16026 16011 -15
|
a5560dd
to
47bf6a5
Compare
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good at first glance, but I'm missing the context on why we are doing this. Is there an issue discussing the benefit of this change?
server/src/main/java/org/opensearch/cluster/coordination/PublicationTransportHandler.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/transport/CompressibleBytesOutputStream.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/transport/TransportDecompressor.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/mapper/BinaryFieldMapperTests.java
Outdated
Show resolved
Hide resolved
1b8d6f5
to
ba3ceae
Compare
Gradle Check (Jenkins) Run Completed with:
|
ba3ceae
to
86f548f
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Removed a deprecated COMPRESSOR variable from CompressorFactory and use DEFLATE_COMPRESSOR instea Signed-off-by: Andrey Pleskach <[email protected]>
86f548f
to
1b833b1
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7907-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c7493203bbedc96efb88581a80198d8d26771db
# Push it to GitHub
git push --set-upstream origin backport/backport-7907-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
Will need a manual backport @willyborankin if you want it in 2.x. |
…#7907) Removed a deprecated COMPRESSOR variable from CompressorFactory and use DEFLATE_COMPRESSOR instea Signed-off-by: Andrey Pleskach <[email protected]>
…#7907) Removed a deprecated COMPRESSOR variable from CompressorFactory and use DEFLATE_COMPRESSOR instea Signed-off-by: Andrey Pleskach <[email protected]>
…#7907) Removed a deprecated COMPRESSOR variable from CompressorFactory and use DEFLATE_COMPRESSOR instea Signed-off-by: Andrey Pleskach <[email protected]>
…#7907) Removed a deprecated COMPRESSOR variable from CompressorFactory and use DEFLATE_COMPRESSOR instea Signed-off-by: Andrey Pleskach <[email protected]>
Removed a deprecated COMPRESSOR variable from CompressorFactory and use DEFLATE_COMPRESSOR instea Signed-off-by: Andrey Pleskach <[email protected]>
…#7907) (opensearch-project#8055) Removed a deprecated COMPRESSOR variable from CompressorFactory and use DEFLATE_COMPRESSOR instea Signed-off-by: Andrey Pleskach <[email protected]>
…#7907) Removed a deprecated COMPRESSOR variable from CompressorFactory and use DEFLATE_COMPRESSOR instea Signed-off-by: Andrey Pleskach <[email protected]> Signed-off-by: Rishab Nahata <[email protected]>
…#7907) Removed a deprecated COMPRESSOR variable from CompressorFactory and use DEFLATE_COMPRESSOR instea Signed-off-by: Andrey Pleskach <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
The aim of this PR is to remove a deprecated
COMPRESSOR
variable fromCompressorFactory
and useDEFLATE_COMPRESSOR
instead.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.