Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Fix flaky test - closes #7703 #7879

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

ashking94
Copy link
Member

Description

Fixes flaky test org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure. For the fix, we have increased the timeout to 90s.

Related Issues

Resolves #7703

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashking94 ashking94 changed the title Fix flaky test - closes #7703 [Remote Store] Fix flaky test - closes #7703 Jun 2, 2023
@ashking94 ashking94 self-assigned this Jun 2, 2023
@ashking94 ashking94 added Storage:Durability Issues and PRs related to the durability framework v2.9.0 'Issues and PRs related to version v2.9.0' labels Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #7879 (6ccff27) into main (ecd0879) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 6ccff27 differs from pull request most recent head 7ff59bd. Consider uploading reports for the commit 7ff59bd to get more accurate results

@@             Coverage Diff              @@
##               main    #7879      +/-   ##
============================================
+ Coverage     70.74%   70.78%   +0.03%     
- Complexity    56201    56213      +12     
============================================
  Files          4687     4687              
  Lines        266242   266242              
  Branches      39096    39096              
============================================
+ Hits         188364   188447      +83     
+ Misses        61905    61850      -55     
+ Partials      15973    15945      -28     

see 469 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@gbbafna gbbafna merged commit 5d5e8ad into opensearch-project:main Jun 2, 2023
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Jun 2, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 2, 2023
Signed-off-by: Ashish Singh <[email protected]>
(cherry picked from commit 5d5e8ad)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Jun 2, 2023
(cherry picked from commit 5d5e8ad)

Signed-off-by: Ashish Singh <[email protected]>
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog Storage:Durability Issues and PRs related to the durability framework v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure is flaky
2 participants