-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Use engine codec and replica shard ReplicationCheckpoint for replication events #7732
Conversation
…heckpoint for replication events Signed-off-by: Suraj Singh <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Suraj Singh <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Suraj Singh <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/index/shard/IndexShard.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7732 +/- ##
============================================
+ Coverage 70.63% 70.65% +0.01%
+ Complexity 56099 56078 -21
============================================
Files 4680 4680
Lines 266083 266080 -3
Branches 39074 39074
============================================
+ Hits 187955 188005 +50
+ Misses 62187 62111 -76
- Partials 15941 15964 +23
|
server/src/main/java/org/opensearch/index/shard/IndexShard.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Suraj Singh <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
The codecov violation is reported on code which changed due to refactor rather actual functionality test. Added unit tests for ForceSegmentSync handler to increase the coverage. |
…heckpoint for replication events (#7732) * [Segment Replication] Use engine codec and replica shard ReplicationCheckpoint for replication events Signed-off-by: Suraj Singh <[email protected]> * Spotless fix Signed-off-by: Suraj Singh <[email protected]> * Fix failing unit test Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Address review comments rename Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport handler Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport failure Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit adf7e2c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…heckpoint for replication events (#7732) (#7769) * [Segment Replication] Use engine codec and replica shard ReplicationCheckpoint for replication events * Spotless fix * Fix failing unit test * Address review comments * Address review comments rename * Address review comments * Add unit test for ForceSegmentSync transport handler * Add unit test for ForceSegmentSync transport failure --------- (cherry picked from commit adf7e2c) Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.7 2.7
# Navigate to the new working tree
pushd ../.worktrees/backport-2.7
# Create a new branch
git switch --create backport/backport-7732-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 adf7e2cdfbc13013448bc07ddac0fe09c07fd7e5
# Push it to GitHub
git push --set-upstream origin backport/backport-7732-to-2.7
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.7 Then, create a pull request where the |
…heckpoint for replication events (opensearch-project#7732) * [Segment Replication] Use engine codec and replica shard ReplicationCheckpoint for replication events Signed-off-by: Suraj Singh <[email protected]> * Spotless fix Signed-off-by: Suraj Singh <[email protected]> * Fix failing unit test Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Address review comments rename Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport handler Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport failure Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]>
…heckpoint for replication events (opensearch-project#7732) * [Segment Replication] Use engine codec and replica shard ReplicationCheckpoint for replication events Signed-off-by: Suraj Singh <[email protected]> * Spotless fix Signed-off-by: Suraj Singh <[email protected]> * Fix failing unit test Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Address review comments rename Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport handler Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport failure Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]>
…heckpoint for replication events (#7789) * [Segment Replication] Use engine codec and replica shard ReplicationCheckpoint for replication events (#7732) * [Segment Replication] Use engine codec and replica shard ReplicationCheckpoint for replication events Signed-off-by: Suraj Singh <[email protected]> * Spotless fix Signed-off-by: Suraj Singh <[email protected]> * Fix failing unit test Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Address review comments rename Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport handler Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport failure Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> * Spotless fix after merge conflict resolution Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]>
…heckpoint for replication events (opensearch-project#7732) * [Segment Replication] Use engine codec and replica shard ReplicationCheckpoint for replication events Signed-off-by: Suraj Singh <[email protected]> * Spotless fix Signed-off-by: Suraj Singh <[email protected]> * Fix failing unit test Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Address review comments rename Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport handler Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport failure Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]>
…heckpoint for replication events (opensearch-project#7732) * [Segment Replication] Use engine codec and replica shard ReplicationCheckpoint for replication events Signed-off-by: Suraj Singh <[email protected]> * Spotless fix Signed-off-by: Suraj Singh <[email protected]> * Fix failing unit test Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Address review comments rename Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport handler Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport failure Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]>
…icationCheckpoint for replication events (opensearch-project#7732)" This reverts commit adf7e2c.
…heckpoint for replication events (opensearch-project#7732) (opensearch-project#7769) * [Segment Replication] Use engine codec and replica shard ReplicationCheckpoint for replication events * Spotless fix * Fix failing unit test * Address review comments * Address review comments rename * Address review comments * Add unit test for ForceSegmentSync transport handler * Add unit test for ForceSegmentSync transport failure --------- (cherry picked from commit adf7e2c) Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…heckpoint for replication events (opensearch-project#7732) * [Segment Replication] Use engine codec and replica shard ReplicationCheckpoint for replication events Signed-off-by: Suraj Singh <[email protected]> * Spotless fix Signed-off-by: Suraj Singh <[email protected]> * Fix failing unit test Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Address review comments rename Signed-off-by: Suraj Singh <[email protected]> * Address review comments Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport handler Signed-off-by: Suraj Singh <[email protected]> * Add unit test for ForceSegmentSync transport failure Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
ReplicationCheckpoint
param from SegmentReplicationTarget ctor and SegmentReplicationTargetService.startReplication method.Related Issues
Resolves: #7733
Related: #3881
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.