Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SearchPipelineInfo backcompat check #7672

Merged
merged 1 commit into from
May 23, 2023

Conversation

msfroh
Copy link
Collaborator

@msfroh msfroh commented May 22, 2023

Description

Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO (see #7597).

This change should be merged (immediately) after
#7669.

Related Issues

Follows from #7597 and #7669.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@msfroh
Copy link
Collaborator Author

msfroh commented May 22, 2023

I believe that Gradle checks on this PR will fail until #7669 is merged.

But after #7669 is merged, other PRs against main will fail until this PR is merged.

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@msfroh
Copy link
Collaborator Author

msfroh commented May 22, 2023

I believe that Gradle checks on this PR will fail until #7669 is merged.

But after #7669 is merged, other PRs against main will fail until this PR is merged.

Sure enough, any upgrade / BWC test is failing as NodeInfos don't propagate properly between 2.8 and 3.0.

So, we'll need to merge #7669, then retry the Gradle check on this one.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@msfroh msfroh force-pushed the update-version-check-7597 branch 2 times, most recently from f7ea6cf to 327d2f9 Compare May 23, 2023 01:32
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationIT.testReplicationPostDeleteAndForceMerge

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #7672 (290d8cc) into main (959910b) will increase coverage by 0.09%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##               main    #7672      +/-   ##
============================================
+ Coverage     70.68%   70.77%   +0.09%     
- Complexity    56095    56121      +26     
============================================
  Files          4680     4680              
  Lines        266076   266081       +5     
  Branches      39065    39067       +2     
============================================
+ Hits         188068   188313     +245     
+ Misses        62101    61823     -278     
- Partials      15907    15945      +38     
Impacted Files Coverage Δ
...g/opensearch/cluster/routing/OperationRouting.java 80.35% <80.00%> (-0.02%) ⬇️
...opensearch/search/pipeline/SearchPipelineInfo.java 72.41% <100.00%> (ø)

... and 451 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Now that we've backported the SearchPipelineInfo serialization change to
2.x ahead of the 2.8 release, we need to update the compatibility check
from <=2.8 to <2.8, as mentioned in the previous TODO.

This change should be merged (immediately) after
opensearch-project#7669.

Signed-off-by: Michael Froh <[email protected]>
@msfroh msfroh force-pushed the update-version-check-7597 branch from 327d2f9 to 290d8cc Compare May 23, 2023 02:30
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@gashutos
Copy link
Contributor

Lets merge this ? Most of the PRs are red...

@reta reta merged commit b4b3724 into opensearch-project:main May 23, 2023
suranjay pushed a commit to suranjay/OpenSearch that referenced this pull request May 29, 2023
Now that we've backported the SearchPipelineInfo serialization change to
2.x ahead of the 2.8 release, we need to update the compatibility check
from <=2.8 to <2.8, as mentioned in the previous TODO.

This change should be merged (immediately) after
opensearch-project#7669.

Signed-off-by: Michael Froh <[email protected]>
stephen-crawford pushed a commit to stephen-crawford/OpenSearch that referenced this pull request May 31, 2023
Now that we've backported the SearchPipelineInfo serialization change to
2.x ahead of the 2.8 release, we need to update the compatibility check
from <=2.8 to <2.8, as mentioned in the previous TODO.

This change should be merged (immediately) after
opensearch-project#7669.

Signed-off-by: Michael Froh <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Now that we've backported the SearchPipelineInfo serialization change to
2.x ahead of the 2.8 release, we need to update the compatibility check
from <=2.8 to <2.8, as mentioned in the previous TODO.

This change should be merged (immediately) after
opensearch-project#7669.

Signed-off-by: Michael Froh <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants