-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SearchPipelineInfo backcompat check #7672
Update SearchPipelineInfo backcompat check #7672
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Gradle Check (Jenkins) Run Completed with:
|
Sure enough, any upgrade / BWC test is failing as NodeInfos don't propagate properly between 2.8 and 3.0. So, we'll need to merge #7669, then retry the Gradle check on this one. |
Gradle Check (Jenkins) Run Completed with:
|
f7ea6cf
to
327d2f9
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7672 +/- ##
============================================
+ Coverage 70.68% 70.77% +0.09%
- Complexity 56095 56121 +26
============================================
Files 4680 4680
Lines 266076 266081 +5
Branches 39065 39067 +2
============================================
+ Hits 188068 188313 +245
+ Misses 62101 61823 -278
- Partials 15907 15945 +38
|
Gradle Check (Jenkins) Run Completed with:
|
Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO. This change should be merged (immediately) after opensearch-project#7669. Signed-off-by: Michael Froh <[email protected]>
327d2f9
to
290d8cc
Compare
Gradle Check (Jenkins) Run Completed with:
|
Lets merge this ? Most of the PRs are red... |
Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO. This change should be merged (immediately) after opensearch-project#7669. Signed-off-by: Michael Froh <[email protected]>
Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO. This change should be merged (immediately) after opensearch-project#7669. Signed-off-by: Michael Froh <[email protected]>
Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO. This change should be merged (immediately) after opensearch-project#7669. Signed-off-by: Michael Froh <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO (see #7597).
This change should be merged (immediately) after
#7669.
Related Issues
Follows from #7597 and #7669.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.