[Backport 2.x] Create NamedRoute to map extension routes to a shortened name #7631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* WIP on rest layer authz Signed-off-by: Craig Perkins <[email protected]> * Create PermissibleRoute Signed-off-by: Craig Perkins <[email protected]> * Update extension handshake Signed-off-by: Craig Perkins <[email protected]> * Add connectToNodeAsExtension in TransportService Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Update RouteHandler Signed-off-by: Craig Perkins <[email protected]> * Update java docstrings Signed-off-by: Craig Perkins <[email protected]> * Run spotlessApply Signed-off-by: Craig Perkins <[email protected]> * Fix merge conflicts Signed-off-by: Craig Perkins <[email protected]> * Rename to ProtectedRoute Signed-off-by: Craig Perkins <[email protected]> * Create method to get extension settings from extensions.yml Signed-off-by: Craig Perkins <[email protected]> * Add ExtensionsManager.lookupExtensionSettings Signed-off-by: Craig Perkins <[email protected]> * Small change to name Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> * Move extensionSettingsMap.put Signed-off-by: Craig Perkins <[email protected]> * Re-run CI Signed-off-by: Craig Perkins <[email protected]> * Address review feedback Signed-off-by: Craig Perkins <[email protected]> * Add test for ProtectedRoute Signed-off-by: Craig Perkins <[email protected]> * spotlessApply Signed-off-by: Craig Perkins <[email protected]> * Add RouteHandlerTests Signed-off-by: Craig Perkins <[email protected]> * Switch to NamedRoute and add validation for action naming Signed-off-by: Craig Perkins <[email protected]> * Avoid magic numbers Signed-off-by: Craig Perkins <[email protected]> * Remove @test annotation Signed-off-by: Craig Perkins <[email protected]> * Address code review feedback Signed-off-by: Craig Perkins <[email protected]> * Update error message Signed-off-by: Craig Perkins <[email protected]> * Check for REST Action name uniqueness across all registered actions Signed-off-by: Craig Perkins <[email protected]> * minimize code in the test Signed-off-by: Craig Perkins <[email protected]> * Update changelog Signed-off-by: Craig Perkins <[email protected]> * Add DynamicRouteRegistry Signed-off-by: Craig Perkins <[email protected]> * Address code review feedback Signed-off-by: Craig Perkins <[email protected]> * Add mock DynamicRouteRegistry.class Signed-off-by: Craig Perkins <[email protected]> * Add RouteRegistry to DynamicActionModule Signed-off-by: Craig Perkins <[email protected]> * Pass around dynamicActionRegistry instead of ActionModule Signed-off-by: Craig Perkins <[email protected]> * Only pass dynamic action registry Signed-off-by: Craig Perkins <[email protected]> * Add DynamicActionRegistryTests for tests of dynamic registry Signed-off-by: Craig Perkins <[email protected]> * Move CHANGELOG entry Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 8470df6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng and
VachaShah
as code owners
owaiskazi19
approved these changes
May 18, 2023
reta
approved these changes
May 18, 2023
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #7631 +/- ##
============================================
+ Coverage 70.29% 70.34% +0.04%
+ Complexity 59951 59941 -10
============================================
Files 4882 4884 +2
Lines 288357 288428 +71
Branches 41935 41949 +14
============================================
+ Hits 202697 202884 +187
+ Misses 68619 68513 -106
+ Partials 17041 17031 -10
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8470df6 from #6870.