Fix flaky test SegmentReplicationIT.testScrollWithOngoingSegmentReplication #7572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation This test has flaky failures for two reasons: 1. Fetches list of temporary files on disk starting with ".replication" before the replica has time to flush received chunks to disk. Fixed by wrapping the assertion that a tmp file exists with assertBusy. 2. Asserts that the count of tmp files is exactly the same before/after a scroll request is cleared. However, it is possible that additional tmp files have been written to disk concurrently, causing a count mismatch. Fixed by removing the size assertion. For the sake of this test we don't care if this is the case, as long as the tmp files originally fetched remain after a scroll query is cleared. Signed-off-by: Marc Handalian <[email protected]>
mch2
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng and
VachaShah
as code owners
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7572 +/- ##
============================================
+ Coverage 70.54% 70.60% +0.05%
- Complexity 59713 59753 +40
============================================
Files 4896 4896
Lines 286798 286798
Branches 41331 41331
============================================
+ Hits 202334 202481 +147
+ Misses 67761 67646 -115
+ Partials 16703 16671 -32 |
dreamer-89
approved these changes
May 16, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 16, 2023
…cation (#7572) This test has flaky failures for two reasons: 1. Fetches list of temporary files on disk starting with ".replication" before the replica has time to flush received chunks to disk. Fixed by wrapping the assertion that a tmp file exists with assertBusy. 2. Asserts that the count of tmp files is exactly the same before/after a scroll request is cleared. However, it is possible that additional tmp files have been written to disk concurrently, causing a count mismatch. Fixed by removing the size assertion. For the sake of this test we don't care if this is the case, as long as the tmp files originally fetched remain after a scroll query is cleared. Signed-off-by: Marc Handalian <[email protected]> (cherry picked from commit 804bef4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89
pushed a commit
that referenced
this pull request
May 16, 2023
…cation (#7572) (#7588) This test has flaky failures for two reasons: 1. Fetches list of temporary files on disk starting with ".replication" before the replica has time to flush received chunks to disk. Fixed by wrapping the assertion that a tmp file exists with assertBusy. 2. Asserts that the count of tmp files is exactly the same before/after a scroll request is cleared. However, it is possible that additional tmp files have been written to disk concurrently, causing a count mismatch. Fixed by removing the size assertion. For the sake of this test we don't care if this is the case, as long as the tmp files originally fetched remain after a scroll query is cleared. (cherry picked from commit 804bef4) Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
stephen-crawford
pushed a commit
to stephen-crawford/OpenSearch
that referenced
this pull request
May 31, 2023
…cation (opensearch-project#7572) This test has flaky failures for two reasons: 1. Fetches list of temporary files on disk starting with ".replication" before the replica has time to flush received chunks to disk. Fixed by wrapping the assertion that a tmp file exists with assertBusy. 2. Asserts that the count of tmp files is exactly the same before/after a scroll request is cleared. However, it is possible that additional tmp files have been written to disk concurrently, causing a count mismatch. Fixed by removing the size assertion. For the sake of this test we don't care if this is the case, as long as the tmp files originally fetched remain after a scroll query is cleared. Signed-off-by: Marc Handalian <[email protected]>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…cation (opensearch-project#7572) This test has flaky failures for two reasons: 1. Fetches list of temporary files on disk starting with ".replication" before the replica has time to flush received chunks to disk. Fixed by wrapping the assertion that a tmp file exists with assertBusy. 2. Asserts that the count of tmp files is exactly the same before/after a scroll request is cleared. However, it is possible that additional tmp files have been written to disk concurrently, causing a count mismatch. Fixed by removing the size assertion. For the sake of this test we don't care if this is the case, as long as the tmp files originally fetched remain after a scroll query is cleared. Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix flaky test SegmentReplicationIT.testScrollWithOngoingSegmentReplication
This test has flaky failures for two reasons:
flush received chunks to disk. Fixed by wrapping the assertion that a tmp file exists with assertBusy.
it is possible that additional tmp files have been written to disk concurrently, causing a count mismatch. Fixed
by removing the size assertion. For the sake of this test we don't care if this is the case, as long as the tmp files
originally fetched remain after a scroll query is cleared.
Related Issues
resolves #7569
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.