-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide mechanism to configure XContent parsing constraints (after update to Jackson 2.15.0 and above) #7550
Conversation
@andrross @dblock curious what do you think folks, @martin-gaievski @ylwu-amzn fyi |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7550 +/- ##
============================================
+ Coverage 70.47% 70.57% +0.09%
- Complexity 59728 59764 +36
============================================
Files 4896 4896
Lines 286798 286810 +12
Branches 41331 41331
============================================
+ Hits 202133 202426 +293
+ Misses 68078 67705 -373
- Partials 16587 16679 +92
|
Gradle Check (Jenkins) Run Completed with:
|
02a3321
to
14be00c
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
libs/x-content/src/test/java/org/opensearch/common/xcontent/XContentParserTests.java
Show resolved
Hide resolved
libs/x-content/src/test/java/org/opensearch/common/xcontent/XContentParserTests.java
Outdated
Show resolved
Hide resolved
…date to Jackson 2.15.0 and above) Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
@andrross could you please review again, seems that Andriy (reta) has been addressed your previous comments? This change should unblock several plugins that are blocked by jackson 2.15 upgrade |
…date to Jackson 2.15.0 and above) (#7550) * Provide mechanism to configure XContent parsing constraints (after update to Jackson 2.15.0 and above) Signed-off-by: Andriy Redko <[email protected]> * Address code review comments Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 03e41e3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@reta Sorry I missed this prior to merging, but since this introduces a new setting for cluster operators I think this merits a changelog entry. What do you think? |
I will do that (in a moment) and also include the documentation issue, thank you |
…aints (after update to Jackson 2.15.0 and above) (#7584) * Provide mechanism to configure XContent parsing constraints (after update to Jackson 2.15.0 and above) (#7550) * Provide mechanism to configure XContent parsing constraints (after update to Jackson 2.15.0 and above) Signed-off-by: Andriy Redko <[email protected]> * Address code review comments Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 03e41e3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add changelog entry from #7587 Signed-off-by: Andrew Ross <[email protected]> * Lift the XContent parsing constraint limits to preserve backward compatibility Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrew Ross <[email protected]> Co-authored-by: Andriy Redko <[email protected]>
…date to Jackson 2.15.0 and above) (opensearch-project#7550) * Provide mechanism to configure XContent parsing constraints (after update to Jackson 2.15.0 and above) Signed-off-by: Andriy Redko <[email protected]> * Address code review comments Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]>
…date to Jackson 2.15.0 and above) (opensearch-project#7550) * Provide mechanism to configure XContent parsing constraints (after update to Jackson 2.15.0 and above) Signed-off-by: Andriy Redko <[email protected]> * Address code review comments Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Provide mechanism to configure XContent parsing constraints (after update to Jackson 2.15.0 and above)
Related Issues
Resolves #7549
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.