-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filecache support in clear indices cache API #7498
Add filecache support in clear indices cache API #7498
Conversation
f2058ab
to
b004da9
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7498 +/- ##
============================================
- Coverage 70.61% 70.57% -0.04%
+ Complexity 59794 59776 -18
============================================
Files 4896 4897 +1
Lines 286899 286805 -94
Branches 41350 41336 -14
============================================
- Hits 202585 202405 -180
- Misses 67633 67737 +104
+ Partials 16681 16663 -18
|
b004da9
to
38dcb96
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
38dcb96
to
ab0f262
Compare
...n/java/org/opensearch/action/admin/indices/cache/clear/TransportClearIndicesCacheAction.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
f4edc94
to
c829953
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
...n/java/org/opensearch/action/admin/indices/cache/clear/TransportClearIndicesCacheAction.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/store/remote/utils/cache/RefCountedCacheTestCase.java
Outdated
Show resolved
Hide resolved
c829953
to
d88da42
Compare
server/src/test/java/org/opensearch/index/store/remote/filecache/FileCacheTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please create a documentation issue [1] to update the existing Cache APIs with a new parameter, thank you.
[1] https://github.com/opensearch-project/documentation-website
Gradle Check (Jenkins) Run Completed with:
|
Will update the cache size based on CI node specs. |
Signed-off-by: Kunal Kotwani <[email protected]>
d88da42
to
d85292e
Compare
Gradle Check (Jenkins) Run Completed with:
|
Unrelated to the changes. Created an issue - #7592 |
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7498-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a1e42b1131d5d807dc66d13dd960ebe707da3f09
# Push it to GitHub
git push --set-upstream origin backport/backport-7498-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…7498) Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit a1e42b1)
…7498) Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit a1e42b1)
…7498) Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit a1e42b1) Signed-off-by: Kunal Kotwani <[email protected]>
… filecache support in clear indices cache API (#7595) * Remove LinkedDeque and replace with LinkedHashMap (#6968) * Remove LinkedDeque and replace with LinkedHashMap After the recent changes the usage of the LinkedDeque fits quite well with the insertion order semantics of LinkedHashMap, which also allows for constant time additions and removals. Signed-off-by: Andrew Ross <[email protected]> * Use class member reference now that lock is final Signed-off-by: Andrew Ross <[email protected]> --------- Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit 65443ad) * Add filecache support in clear indices cache API (#7498) Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit a1e42b1) Signed-off-by: Kunal Kotwani <[email protected]> --------- Signed-off-by: Kunal Kotwani <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
…7498) Signed-off-by: Kunal Kotwani <[email protected]>
…7498) Signed-off-by: Kunal Kotwani <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
file
support to clear out filecache for indices using the clear indices cache APIRelated Issues
Resolves #6030
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.