-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TokenManager Interface #7452
TokenManager Interface #7452
Conversation
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7452 +/- ##
============================================
+ Coverage 70.75% 70.92% +0.17%
- Complexity 56236 56357 +121
============================================
Files 4689 4691 +2
Lines 266324 266388 +64
Branches 39087 39090 +3
============================================
+ Hits 188425 188929 +504
+ Misses 61949 61473 -476
- Partials 15950 15986 +36
|
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/identity/tokens/TokenManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Should be all set @peternied.Let me know if you would like anything else changed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, great step forward!
@peternied @scrawfor99 we are backporting it to |
@reta, yeah we should. Sorry I forgot to label it. Will do that now. |
Add TokenManager to IdentityPlugin Provide an mechanism for identity plugins to manage tokens, lays the groundwork for OnBehalfOf authentication Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Co-authored-by: Andriy Redko <[email protected]> (cherry picked from commit 6fdeae9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Add TokenManager to IdentityPlugin Provide an mechanism for identity plugins to manage tokens, lays the groundwork for OnBehalfOf authentication (cherry picked from commit 6fdeae9) Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <[email protected]>
@@ -86,7 +86,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
### Security | |||
|
|||
## [Unreleased 2.x] | |||
### Added | |||
### Add TokenManager Interface ([#7452](https://github.com/opensearch-project/OpenSearch/pull/7452)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scrawfor99 @peternied Can we fix up this changelog entry on main and and 2.x? The ### Added
header was replaced by this entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move entry for opensearch-project#7321 to correct section and fix the malformed entry from opensearch-project#7452. Signed-off-by: Andrew Ross <[email protected]>
Move entry for #7321 to correct section and fix the malformed entry from #7452. Signed-off-by: Andrew Ross <[email protected]>
Move entry for opensearch-project#7321 to correct section and fix the malformed entry from opensearch-project#7452. Signed-off-by: Andrew Ross <[email protected]>
Move entry for opensearch-project#7321 to correct section and fix the malformed entry from opensearch-project#7452. Signed-off-by: Andrew Ross <[email protected]>
…1.0.83 (#7933) * Update network schema Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> * Add joni and jcoding to path Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update rest-api-spec/src/main/resources/rest-api-spec/api/bulk.json Signed-off-by: Stephen Crawford <[email protected]> * Update rest-api-spec/src/main/resources/rest-api-spec/api/bulk.json Signed-off-by: Stephen Crawford <[email protected]> * Update Apache Lucene to 9.7.0-snapshot-204acc3 (#7887) Signed-off-by: Andriy Redko <[email protected]> * Add bwc version 2.8.1 (#7942) Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> * Fix changelog entries (#7946) Move entry for #7321 to correct section and fix the malformed entry from #7452. Signed-off-by: Andrew Ross <[email protected]> * SegRep with Remote: Add Remote store as a segment replication source (#7653) * SegRep with Remote: Add Remote store as a segment replication source Signed-off-by: Ankit Kala <[email protected]> * Fix Gradle check Signed-off-by: Ankit Kala <[email protected]> * Retrying Gradle check Signed-off-by: Ankit Kala <[email protected]> --------- Signed-off-by: Ankit Kala <[email protected]> * rebase Signed-off-by: Stephen Crawford <[email protected]> * remove empty line Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Ankit Kala <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Andrew Ross <[email protected]> Co-authored-by: Ankit Kala <[email protected]>
…1.0.83 (opensearch-project#7933) * Update network schema Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> * Add joni and jcoding to path Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update rest-api-spec/src/main/resources/rest-api-spec/api/bulk.json Signed-off-by: Stephen Crawford <[email protected]> * Update rest-api-spec/src/main/resources/rest-api-spec/api/bulk.json Signed-off-by: Stephen Crawford <[email protected]> * Update Apache Lucene to 9.7.0-snapshot-204acc3 (opensearch-project#7887) Signed-off-by: Andriy Redko <[email protected]> * Add bwc version 2.8.1 (opensearch-project#7942) Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> * Fix changelog entries (opensearch-project#7946) Move entry for opensearch-project#7321 to correct section and fix the malformed entry from opensearch-project#7452. Signed-off-by: Andrew Ross <[email protected]> * SegRep with Remote: Add Remote store as a segment replication source (opensearch-project#7653) * SegRep with Remote: Add Remote store as a segment replication source Signed-off-by: Ankit Kala <[email protected]> * Fix Gradle check Signed-off-by: Ankit Kala <[email protected]> * Retrying Gradle check Signed-off-by: Ankit Kala <[email protected]> --------- Signed-off-by: Ankit Kala <[email protected]> * rebase Signed-off-by: Stephen Crawford <[email protected]> * remove empty line Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Ankit Kala <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Andrew Ross <[email protected]> Co-authored-by: Ankit Kala <[email protected]>
Add TokenManager to IdentityPlugin Provide an mechanism for identity plugins to manage tokens, lays the groundwork for OnBehalfOf authentication Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Co-authored-by: Andriy Redko <[email protected]>
Move entry for opensearch-project#7321 to correct section and fix the malformed entry from opensearch-project#7452. Signed-off-by: Andrew Ross <[email protected]>
…1.0.83 (opensearch-project#7933) * Update network schema Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> * Add joni and jcoding to path Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update rest-api-spec/src/main/resources/rest-api-spec/api/bulk.json Signed-off-by: Stephen Crawford <[email protected]> * Update rest-api-spec/src/main/resources/rest-api-spec/api/bulk.json Signed-off-by: Stephen Crawford <[email protected]> * Update Apache Lucene to 9.7.0-snapshot-204acc3 (opensearch-project#7887) Signed-off-by: Andriy Redko <[email protected]> * Add bwc version 2.8.1 (opensearch-project#7942) Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> * Fix changelog entries (opensearch-project#7946) Move entry for opensearch-project#7321 to correct section and fix the malformed entry from opensearch-project#7452. Signed-off-by: Andrew Ross <[email protected]> * SegRep with Remote: Add Remote store as a segment replication source (opensearch-project#7653) * SegRep with Remote: Add Remote store as a segment replication source Signed-off-by: Ankit Kala <[email protected]> * Fix Gradle check Signed-off-by: Ankit Kala <[email protected]> * Retrying Gradle check Signed-off-by: Ankit Kala <[email protected]> --------- Signed-off-by: Ankit Kala <[email protected]> * rebase Signed-off-by: Stephen Crawford <[email protected]> * remove empty line Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Ankit Kala <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Andrew Ross <[email protected]> Co-authored-by: Ankit Kala <[email protected]>
…rch-project#7927) Add TokenManager to IdentityPlugin Provide an mechanism for identity plugins to manage tokens, lays the groundwork for OnBehalfOf authentication (cherry picked from commit 6fdeae9) Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <[email protected]>
…1.0.83 (opensearch-project#7933) * Update network schema Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> * Add joni and jcoding to path Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update rest-api-spec/src/main/resources/rest-api-spec/api/bulk.json Signed-off-by: Stephen Crawford <[email protected]> * Update rest-api-spec/src/main/resources/rest-api-spec/api/bulk.json Signed-off-by: Stephen Crawford <[email protected]> * Update Apache Lucene to 9.7.0-snapshot-204acc3 (opensearch-project#7887) Signed-off-by: Andriy Redko <[email protected]> * Add bwc version 2.8.1 (opensearch-project#7942) Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> * Fix changelog entries (opensearch-project#7946) Move entry for opensearch-project#7321 to correct section and fix the malformed entry from opensearch-project#7452. Signed-off-by: Andrew Ross <[email protected]> * SegRep with Remote: Add Remote store as a segment replication source (opensearch-project#7653) * SegRep with Remote: Add Remote store as a segment replication source Signed-off-by: Ankit Kala <[email protected]> * Fix Gradle check Signed-off-by: Ankit Kala <[email protected]> * Retrying Gradle check Signed-off-by: Ankit Kala <[email protected]> --------- Signed-off-by: Ankit Kala <[email protected]> * rebase Signed-off-by: Stephen Crawford <[email protected]> * remove empty line Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Ankit Kala <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Andrew Ross <[email protected]> Co-authored-by: Ankit Kala <[email protected]> Signed-off-by: Rishab Nahata <[email protected]>
Add TokenManager to IdentityPlugin Provide an mechanism for identity plugins to manage tokens, lays the groundwork for OnBehalfOf authentication Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Move entry for opensearch-project#7321 to correct section and fix the malformed entry from opensearch-project#7452. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
…1.0.83 (opensearch-project#7933) * Update network schema Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> * Add joni and jcoding to path Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update buildSrc/src/main/java/org/opensearch/gradle/precommit/ValidateJsonAgainstSchemaTask.java Signed-off-by: Stephen Crawford <[email protected]> * Update rest-api-spec/src/main/resources/rest-api-spec/api/bulk.json Signed-off-by: Stephen Crawford <[email protected]> * Update rest-api-spec/src/main/resources/rest-api-spec/api/bulk.json Signed-off-by: Stephen Crawford <[email protected]> * Update Apache Lucene to 9.7.0-snapshot-204acc3 (opensearch-project#7887) Signed-off-by: Andriy Redko <[email protected]> * Add bwc version 2.8.1 (opensearch-project#7942) Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> * Fix changelog entries (opensearch-project#7946) Move entry for opensearch-project#7321 to correct section and fix the malformed entry from opensearch-project#7452. Signed-off-by: Andrew Ross <[email protected]> * SegRep with Remote: Add Remote store as a segment replication source (opensearch-project#7653) * SegRep with Remote: Add Remote store as a segment replication source Signed-off-by: Ankit Kala <[email protected]> * Fix Gradle check Signed-off-by: Ankit Kala <[email protected]> * Retrying Gradle check Signed-off-by: Ankit Kala <[email protected]> --------- Signed-off-by: Ankit Kala <[email protected]> * rebase Signed-off-by: Stephen Crawford <[email protected]> * remove empty line Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Ankit Kala <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Andrew Ross <[email protected]> Co-authored-by: Ankit Kala <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Creates a generic token manager interface that can be used to handle numerous token types.
This PR addresses this issue.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.