Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change port number for disconnected remote host to accomadate for Win… #7035

Merged

Conversation

kotwanikunal
Copy link
Member

…dows platform execution

Description

  • Uses a port number other than 0 to connect to a non existent cluster to ensure no conflicts on Windows platform

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #7035 (33f957e) into main (53b128f) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #7035      +/-   ##
============================================
- Coverage     70.78%   70.76%   -0.03%     
- Complexity    59269    59271       +2     
============================================
  Files          4823     4823              
  Lines        283985   283985              
  Branches      40953    40954       +1     
============================================
- Hits         201026   200954      -72     
- Misses        66403    66526     +123     
+ Partials      16556    16505      -51     
Impacted Files Coverage Δ
...ter/snapshots/get/TransportGetSnapshotsAction.java 41.58% <0.00%> (ø)

... and 483 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tlfeng tlfeng added the :test Adding or fixing a test label Apr 6, 2023
@kotwanikunal kotwanikunal merged commit cbd478a into opensearch-project:main Apr 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 6, 2023
…dows platform execution (#7035)

Signed-off-by: Kunal Kotwani <[email protected]>
(cherry picked from commit cbd478a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 6, 2023
…dows platform execution (#7035)

Signed-off-by: Kunal Kotwani <[email protected]>
(cherry picked from commit cbd478a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 6, 2023
…dows platform execution (#7035)

Signed-off-by: Kunal Kotwani <[email protected]>
(cherry picked from commit cbd478a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Apr 6, 2023
…dows platform execution (#7035) (#7039)

(cherry picked from commit cbd478a)

Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Apr 6, 2023
…dows platform execution (#7035) (#7040)

(cherry picked from commit cbd478a)

Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Apr 6, 2023
…dows platform execution (#7035) (#7038)

(cherry picked from commit cbd478a)

Signed-off-by: Kunal Kotwani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kotwanikunal kotwanikunal deleted the reindex-no-cluster branch June 12, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 2.x Backport to 2.x branch backport 2.6 Backport to 2.6 branch skip-changelog :test Adding or fixing a test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure ReindexClientYamlTestSuiteIT
4 participants