-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Implement microbenchmark for FileCache #6886
Conversation
The current implementation of the FileCache uses some hand-rolled data structures that would be nice to replace with library implementations. This benchmark will be useful to compare the performance of any future replacements. Sample results (AWS EC2 Ubuntu machine with 32 vCPUs and 64GB of RAM): ``` Benchmark (concurrencyLevel) (maximumNumberOfEntries) Mode Cnt Score Error Units FileCacheBenchmark.get 1 65536 thrpt 2243.092 ops/ms FileCacheBenchmark.get 1 1048576 thrpt 950.818 ops/ms FileCacheBenchmark.get 8 65536 thrpt 5651.150 ops/ms FileCacheBenchmark.get 8 1048576 thrpt 2831.012 ops/ms FileCacheBenchmark.put 1 65536 thrpt 2206.027 ops/ms FileCacheBenchmark.put 1 1048576 thrpt 921.248 ops/ms FileCacheBenchmark.put 8 65536 thrpt 4421.122 ops/ms FileCacheBenchmark.put 8 1048576 thrpt 2624.550 ops/ms FileCacheBenchmark.remove 1 65536 thrpt 12387.999 ops/ms FileCacheBenchmark.remove 1 1048576 thrpt 6324.643 ops/ms FileCacheBenchmark.remove 8 65536 thrpt 22161.031 ops/ms FileCacheBenchmark.remove 8 1048576 thrpt 14826.586 ops/ms FileCacheBenchmark.replace 1 65536 thrpt 2146.572 ops/ms FileCacheBenchmark.replace 1 1048576 thrpt 947.612 ops/ms FileCacheBenchmark.replace 8 65536 thrpt 4405.339 ops/ms FileCacheBenchmark.replace 8 1048576 thrpt 2707.204 ops/ms ``` Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit 5eed61e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #6886 +/- ##
=========================================
Coverage 70.42% 70.42%
Complexity 59444 59444
=========================================
Files 4810 4810
Lines 285519 285519
Branches 41510 41510
=========================================
Hits 201069 201069
Misses 67595 67595
Partials 16855 16855 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Backport 5eed61e from #6610.