[Segment Replication] Fix testAllocationWithDisruption flakyness #6838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Singh <[email protected]>
dreamer-89
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
tlfeng,
VachaShah and
xuezhou25
as code owners
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6838 +/- ##
============================================
+ Coverage 70.65% 70.73% +0.07%
- Complexity 59162 59220 +58
============================================
Files 4812 4812
Lines 283615 283615
Branches 40896 40896
============================================
+ Hits 200394 200615 +221
+ Misses 66764 66565 -199
+ Partials 16457 16435 -22 see 488 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…es of primary accumulation on one node Signed-off-by: Suraj Singh <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Poojita-Raj
reviewed
Mar 27, 2023
...ernalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationAllocationIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Suraj Singh <[email protected]>
Poojita-Raj
approved these changes
Mar 27, 2023
Gradle Check (Jenkins) Run Completed with:
|
Rishikesh1159
approved these changes
Mar 27, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
* [Segment Replication] Fix testAllocationWithDisruption flakyness Signed-off-by: Suraj Singh <[email protected]> * Use more number of nodes with lesser primary shards to decrease chances of primary accumulation on one node Signed-off-by: Suraj Singh <[email protected]> * Update comment Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit 7500270) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89
pushed a commit
that referenced
this pull request
Mar 27, 2023
…) (#6847) * [Segment Replication] Fix testAllocationWithDisruption flakyness * Use more number of nodes with lesser primary shards to decrease chances of primary accumulation on one node * Update comment --------- (cherry picked from commit 7500270) Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mitrofmep
pushed a commit
to mitrofmep/OpenSearch
that referenced
this pull request
Apr 5, 2023
…nsearch-project#6838) * [Segment Replication] Fix testAllocationWithDisruption flakyness Signed-off-by: Suraj Singh <[email protected]> * Use more number of nodes with lesser primary shards to decrease chances of primary accumulation on one node Signed-off-by: Suraj Singh <[email protected]> * Update comment Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: Valentin Mitrofanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing flakyness was due to condition when smaller number of nodes were added but more number of nodes were stopped resulting in lesser number of nodes where re-balance is not possible due to SameShardAllocationDecider. This test changes:
Issues Resolved
Resolves #6565
Testing
Ran the test in continuation with this fix, the test is not failing anymore (ran 800 times without failure).
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.