-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Override segment replication handler for duplicate request from replica #6693
Conversation
…quest from same replica Signed-off-by: Suraj Singh <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/indices/replication/OngoingSegmentReplications.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Suraj Singh <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6693 +/- ##
=======================================
Coverage ? 70.66%
Complexity ? 59159
=======================================
Files ? 4809
Lines ? 283454
Branches ? 40867
=======================================
Hits ? 200291
Misses ? 66706
Partials ? 16457
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ate request from replica (#6693) * [Segment Replication] Override segment replication handler for new request from same replica Signed-off-by: Suraj Singh <[email protected]> * Spotless and use map.compute Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit 6bbe31a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ate request from replica (#6693) (#6699) * [Segment Replication] Override segment replication handler for new request from same replica * Spotless and use map.compute --------- (cherry picked from commit 6bbe31a) Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ate request from replica (opensearch-project#6693) * [Segment Replication] Override segment replication handler for new request from same replica Signed-off-by: Suraj Singh <[email protected]> * Spotless and use map.compute Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: Mingshi Liu <[email protected]>
Description
Prevent failures on duplicate segrep request from replica.
With #6636, replica shard handles failures from source node gracefully and clears up its local state without failing replica shard. The primary though can still publish a checkpoint, will trigger replica will start a new round of segrep. With this change, primary first cleans up existing state and create a new one based on request parameters.
Issues Resolved
#6578
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.