[Backport 2.x] Remove seqNo field from ReplicationCheckpoint and use UserData to transfer state.

[mch2]

…nd use UserData to transfer state. (#6594)

• Segment Replication - Fix incorrect maxSeqNo computation.

This change updates getLatestSegmentInfos to only return the max seqNo from the previous commit point. This is the only way to guarantee that up to this seqNo has made it into the commit point.

Signed-off-by: Marc Handalian [email protected]

• Remove unnecessary seqNo field from ReplicationCheckpoint.

Signed-off-by: Marc Handalian [email protected]

Description

Backport #6594

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/12185/
• CommitID: 2efcb0c
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[dreamer-89]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/12185/
• CommitID: 2efcb0c
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

PR needs some fixing @mch2

> Task :server:compileJava
/var/jenkins/workspace/gradle-check/search/server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTarget.java:223: error: method finalizeReplication in class IndexShard cannot be applied to given types;
                indexShard.finalizeReplication(infos);
                          ^
  required: SegmentInfos,long
  found:    SegmentInfos
  reason: actual and formal argument lists differ in length

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/12197/
• CommitID: ed4fdeb
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled

• URL: https://build.ci.opensearch.org/job/gradle-check/12202/
• CommitID: 2284d3b
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov-commenter]

Codecov Report

Merging #6601 (2284d3b) into 2.x (d9d1dc8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6601      +/-   ##
============================================
+ Coverage     70.39%   70.44%   +0.04%     
- Complexity    59272    59346      +74     
============================================
  Files          4800     4800              
  Lines        284608   284602       -6     
  Branches      41353    41352       -1     
============================================
+ Hits         200350   200478     +128     
+ Misses        67463    67382      -81     
+ Partials      16795    16742      -53     

Impacted Files	Coverage Δ
.../opensearch/index/engine/NRTReplicationEngine.java	77.16% <100.00%> (-0.48%)	⬇️
...in/java/org/opensearch/index/shard/IndexShard.java	69.96% <100.00%> (+0.61%)	⬆️
.../indices/replication/SegmentReplicationTarget.java	93.20% <100.00%> (ø)
.../replication/checkpoint/ReplicationCheckpoint.java	56.41% <100.00%> (-0.41%)	⬇️

... and 477 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.