Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication ]Remove state update of singleIndexWithSegmentReplicationDisabled in TransportSegmentReplicationStatsAction Class #6526

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

Rishikesh1159
Copy link
Member

Description

This PR fixes bug of _cat/segment_replication API giving incorrect results. TransportSegmentReplicationStatsAction Class is a Singleton so we cannot do a global state update of singleIndexWithSegmentReplicationDisabled, which on concurrent request might incorrectly fail

Issues Resolved

#5718

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Gradle Check (Jenkins) Run Completed with:

@Rishikesh1159 Rishikesh1159 added the backport 2.x Backport to 2.x branch label Mar 2, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #6526 (c4d2913) into main (41cc4df) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #6526      +/-   ##
============================================
- Coverage     70.80%   70.65%   -0.16%     
+ Complexity    59128    59028     -100     
============================================
  Files          4802     4802              
  Lines        282970   282965       -5     
  Branches      40793    40792       -1     
============================================
- Hits         200344   199916     -428     
- Misses        66176    66614     +438     
+ Partials      16450    16435      -15     
Impacted Files Coverage Δ
...cation/TransportSegmentReplicationStatsAction.java 10.81% <ø> (-0.31%) ⬇️
...ces/replication/PrimaryShardReplicationSource.java 96.00% <100.00%> (-0.30%) ⬇️
.../opensearch/test/transport/CapturingTransport.java 96.42% <100.00%> (+0.42%) ⬆️
...a/org/opensearch/test/transport/MockTransport.java 86.79% <100.00%> (+0.51%) ⬆️
...g/opensearch/index/analysis/CharFilterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...adonly/AddIndexBlockClusterStateUpdateRequest.java 0.00% <0.00%> (-75.00%) ⬇️
.../org/opensearch/client/indices/AnalyzeRequest.java 31.00% <0.00%> (-45.00%) ⬇️
...readonly/TransportVerifyShardIndexBlockAction.java 9.75% <0.00%> (-41.47%) ⬇️
...indices/readonly/TransportAddIndexBlockAction.java 20.68% <0.00%> (-37.94%) ⬇️
...earch/client/indices/GetIndexTemplatesRequest.java 38.46% <0.00%> (-34.62%) ⬇️
... and 502 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 2, 2023
Signed-off-by: Rishikesh1159 <[email protected]>
(cherry picked from commit ee305d0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Rishikesh1159 pushed a commit that referenced this pull request Mar 2, 2023
…) (#6527)

(cherry picked from commit ee305d0)

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mingshl pushed a commit to mingshl/OpenSearch-Mingshl that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants