Add workflow to publish maven snapshots #6394
Merged
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaiksaya
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
gaiksaya
force-pushed
the
mvn-publish
branch
from
cebbc20 to
aee4321
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
reviewed
Feb 21, 2023
owaiskazi19
approved these changes
Feb 21, 2023
andrross
reviewed
Feb 21, 2023
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| - Support for HTTP/2 (server-side) ([#3847](https://github.com/opensearch-project/OpenSearch/pull/3847)) | |||
| - Add getter for path field in NestedQueryBuilder ([#4636](https://github.com/opensearch-project/OpenSearch/pull/4636)) | |||
| - Allow mmap to use new JDK-19 preview APIs in Apache Lucene 9.4+ ([#5151](https://github.com/opensearch-project/OpenSearch/pull/5151)) | |||
| - Add workflow to publish maven snapshots ([#6394](https://github.com/opensearch-project/OpenSearch/pull/6394)) | |||
There was a problem hiding this comment.
I think we can skip the changelog for build-related changes
| push: | ||
| branches: | ||
| - main | ||
| - 1.* |
There was a problem hiding this comment.
Will this publish snapshots for like 1.0, 1.1, 1.2 etc? We're only supporting the 1.3 version in the 1.x line so that doesn't seem necessary. Same goes for 2.x where I think the 2.x branch is all we would need. (Unless I'm misunderstanding what the * does here...)
There was a problem hiding this comment.
You are understanding right! Let me know what should be the trigger values here. I am assuming you want main, 1.x and 2.x? Added the same
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6394 +/- ##
============================================
- Coverage 70.62% 70.57% -0.06%
+ Complexity 58930 58909 -21
============================================
Files 4799 4799
Lines 282440 282440
Branches 40719 40719
============================================
- Hits 199477 199328 -149
- Misses 66580 66726 +146
- Partials 16383 16386 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
reta
approved these changes
Feb 21, 2023
andrross
reviewed
Feb 21, 2023
| push: | ||
| branches: | ||
| - main | ||
| - 1.x |
There was a problem hiding this comment.
I think we want 1.3. The only releases we'll do for major version 1 are patch releases on 1.3 (e.g. 1.3.9), which come from the 1.3 branch.
2.x and main are correct for the other branches though.
There was a problem hiding this comment.
So replace 1.x with 1.3? Done
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
force-pushed
the
mvn-publish
branch
from
b3dab15 to
c41cfac
Compare
kotwanikunal
approved these changes
Feb 21, 2023
andrross
approved these changes
Feb 21, 2023
Gradle Check (Jenkins) Run Completed with:
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Sayali Gaikawad <[email protected]> (cherry picked from commit 267e162) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kartg
pushed a commit
that referenced
this pull request
Feb 22, 2023
(cherry picked from commit 267e162) Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Sayali Gaikawad <[email protected]> (cherry picked from commit 267e162) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
(cherry picked from commit 267e162) Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 06f6486) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kartg
pushed a commit
that referenced
this pull request
Feb 22, 2023
(cherry picked from commit 267e162) Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Sayali Gaikawad <[email protected]> (cherry picked from commit 267e162) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19
pushed a commit
that referenced
this pull request
Mar 17, 2023
(cherry picked from commit 267e162) Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds workflow to publish snapshots to maven
gist of what snapshots publication will look like:
Issues Resolved
resolves #6365
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.