-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Add changelog entry and fix allocation test #6250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Singh <[email protected]>
dreamer-89
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
tlfeng,
VachaShah and
xuezhou25
as code owners
February 9, 2023 01:21
andrross
reviewed
Feb 9, 2023
Signed-off-by: Suraj Singh <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Unrelated failure. Retrying gradle check
|
Gradle Check (Jenkins) Run Completed with:
|
Segrep test failure. Created #6259 to track this test failure. Retrying!
|
Gradle Check (Jenkins) Run Completed with:
|
andrross
approved these changes
Feb 9, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 9, 2023
) * [Segment Replication] Add changelog entry and fix allocation test Signed-off-by: Suraj Singh <[email protected]> * Add space Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit f8102d1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89
pushed a commit
that referenced
this pull request
Feb 9, 2023
) (#6270) * [Segment Replication] Add changelog entry and fix allocation test * Add space --------- (cherry picked from commit f8102d1) Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89
added a commit
to dreamer-89/OpenSearch
that referenced
this pull request
Feb 22, 2023
…test (opensearch-project#6250) (opensearch-project#6270)" This reverts commit 726c068.
dreamer-89
added a commit
to dreamer-89/OpenSearch
that referenced
this pull request
Feb 22, 2023
…test (opensearch-project#6250)" This reverts commit f8102d1.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
* Revert "[Segment Replication] Add changelog entry and fix allocation test (#6250) (#6270)" This reverts commit 726c068. * Revert "[Segment Replication] Introduce primary weight factor for primary shards distribution (#6017) (#6161)" This reverts commit 2e3e1ed. (cherry picked from commit e316959) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89
pushed a commit
that referenced
this pull request
Feb 22, 2023
…6444) * Revert "[Segment Replication] Add changelog entry and fix allocation test (#6250) (#6270)" This reverts commit 726c068. * Revert "[Segment Replication] Introduce primary weight factor for primary shards distribution (#6017) (#6161)" This reverts commit 2e3e1ed. (cherry picked from commit e316959) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the changelog entry for PR #6017 which introduces a dynamic setting exposed to end user and thus deserves entry in changelog.
This PR also uses this opportunity to fix one issue in allocation test to use
replicaCount
for number of replicas instead of constant.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.