Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Add changelog entry and fix allocation test #6250

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Feb 9, 2023

Description

This change adds the changelog entry for PR #6017 which introduces a dynamic setting exposed to end user and thus deserves entry in changelog.
This PR also uses this opportunity to fix one issue in allocation test to use replicaCount for number of replicas instead of constant.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Suraj Singh <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

Unrelated failure. Retrying gradle check

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':test:fixtures:gcs-fixture:composeUp'.
> Exit-code 1 when calling /usr/bin/docker-compose, stdout: Step 1/11 : FROM ubuntu:18.04
  18.04: Pulling from library/ubuntu
  Digest: sha256:a3765b4d74747b5e9bdd03205b3fbc4fa19a02781c185f97f24c8f4f84ed7bbf
  Status: Downloaded newer image for ubuntu:18.04
   ---> 5d2df19066ac
  Step 2/11 : RUN apt-get update -qqy
   ---> Running in 598a6b7426cb
  Removing intermediate container 598a6b7426cb
   ---> db36509a16f1
  Step 3/11 : RUN apt-get install -qqy openjdk-11-jre-headless
   ---> Running in 5de154369c21
  �[91mE: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/g/glibc/multiarch-support_2.27-3ubuntu1.6_amd64.deb  Connection failed [IP: 185.125.190.36 80]
  E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
  �[0m

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member Author

dreamer-89 commented Feb 9, 2023

Gradle Check (Jenkins) Run Completed with:

Segrep test failure. Created #6259 to track this test failure. Retrying!

> Task :server:internalClusterTest

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.action.admin.ClientTimeoutIT.testSegmentReplicationStatsWithTimeout" -Dtests.seed=9A395F8DCBA089E7 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=sr-Latn -Dtests.timezone=Pacific/Chuuk -Druntime.java=19

org.opensearch.action.admin.ClientTimeoutIT > testSegmentReplicationStatsWithTimeout FAILED
    java.lang.AssertionError: timed out waiting for green state
        at __randomizedtesting.SeedInfo.seed([9A395F8DCBA089E7:66682A8BCC3D53E]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureColor(OpenSearchIntegTestCase.java:1001)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:932)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:921)
        at org.opensearch.action.admin.ClientTimeoutIT.testSegmentReplicationStatsWithTimeout(ClientTimeoutIT.java:177)


Suite: Test class org.opensearch.action.admin.ClientTimeoutIT
  1> [2023-02-09T12:16:46,210][INFO ][o.o.a.a.ClientTimeoutIT  ] [testNodesInfoTimeout] before test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit f8102d1 into opensearch-project:main Feb 9, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 9, 2023
)

* [Segment Replication] Add changelog entry and fix allocation test

Signed-off-by: Suraj Singh <[email protected]>

* Add space

Signed-off-by: Suraj Singh <[email protected]>

---------

Signed-off-by: Suraj Singh <[email protected]>
(cherry picked from commit f8102d1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89 pushed a commit that referenced this pull request Feb 9, 2023
) (#6270)

* [Segment Replication] Add changelog entry and fix allocation test



* Add space



---------


(cherry picked from commit f8102d1)

Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89 added a commit to dreamer-89/OpenSearch that referenced this pull request Feb 22, 2023
dreamer-89 added a commit to dreamer-89/OpenSearch that referenced this pull request Feb 22, 2023
dreamer-89 added a commit that referenced this pull request Feb 22, 2023
* Revert "[Segment Replication] Add changelog entry and fix allocation test (#6250)"

This reverts commit f8102d1.

* Revert "[Segment Replication] Introduce primary weight factor for primary shards distribution (#6017)"

This reverts commit aa21b5f.
dreamer-89 added a commit that referenced this pull request Feb 22, 2023
* Revert "[Segment Replication] Add changelog entry and fix allocation test (#6250) (#6270)"

This reverts commit 726c068.

* Revert "[Segment Replication] Introduce primary weight factor for primary shards distribution (#6017) (#6161)"

This reverts commit 2e3e1ed.
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 22, 2023
* Revert "[Segment Replication] Add changelog entry and fix allocation test (#6250) (#6270)"

This reverts commit 726c068.

* Revert "[Segment Replication] Introduce primary weight factor for primary shards distribution (#6017) (#6161)"

This reverts commit 2e3e1ed.

(cherry picked from commit e316959)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89 pushed a commit that referenced this pull request Feb 22, 2023
…6444)

* Revert "[Segment Replication] Add changelog entry and fix allocation test (#6250) (#6270)"

This reverts commit 726c068.

* Revert "[Segment Replication] Introduce primary weight factor for primary shards distribution (#6017) (#6161)"

This reverts commit 2e3e1ed.

(cherry picked from commit e316959)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants