[Backport 2.x] [Segment Replication] Implementing cat/segment_replication API #6244

opensearch-trigger-bot · 2023-02-08T21:35:56Z

Backport e455f56 from #5718.

* Initial Draft for adding segment_replication API Signed-off-by: Rishikesh1159 <[email protected]> * Adding bytes transfered in each segrep events and additional metrics. Signed-off-by: Rishikesh1159 <[email protected]> * Fix broken tests. Signed-off-by: Rishikesh1159 <[email protected]> * Fix compile errors Signed-off-by: Rishikesh1159 <[email protected]> * Adding Tests and gating logic behind feature flag. Signed-off-by: Rishikesh1159 <[email protected]> * Add java docs and enable query parameter detailed. Signed-off-by: Rishikesh1159 <[email protected]> * Add temporary documentation URL Signed-off-by: Rishikesh1159 <[email protected]> * Fixing failing tests. Signed-off-by: Rishikesh1159 <[email protected]> * Spotless Apply. Signed-off-by: Rishikesh1159 <[email protected]> * Fix media type copile check. Signed-off-by: Rishikesh1159 <[email protected]> * Revert previous changes and fix failing tests. Signed-off-by: Rishikesh1159 <[email protected]> * Apply spotless check. Signed-off-by: Rishikesh1159 <[email protected]> * Refactoring call to segmentreplicationstate. Signed-off-by: Rishikesh1159 <[email protected]> * spotless check Signed-off-by: Rishikesh1159 <[email protected]> * Changing invokation of segment replication shard and filtering API response by shard id Signed-off-by: Rishikesh1159 <[email protected]> * disable feature flag by default. Signed-off-by: Rishikesh1159 <[email protected]> * Apply spotless Signed-off-by: Rishikesh1159 <[email protected]> * Address comments on PR. Signed-off-by: Rishikesh1159 <[email protected]> * Fix gradle check failures Signed-off-by: Rishikesh1159 <[email protected]> * fix failing testSegment_ReplicationActionAction() Signed-off-by: Rishikesh1159 <[email protected]> * Exclude empty segment replication events in API response. Signed-off-by: Rishikesh1159 <[email protected]> * Apply spotless. Signed-off-by: Rishikesh1159 <[email protected]> * Address PR comments and add Integ Tests. Signed-off-by: Rishikesh1159 <[email protected]> * Fix failing testSegmentReplicationApiResponse(). Signed-off-by: Rishikesh1159 <[email protected]> * Refactoring code. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> (cherry picked from commit e455f56) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

github-actions · 2023-02-08T21:44:07Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/10879/
CommitID: b4478a7
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishikesh1159 <[email protected]>

github-actions · 2023-02-08T23:22:09Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/10885/
CommitID: 84a8d3e
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Rishikesh1159 <[email protected]>

github-actions · 2023-02-09T17:04:51Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/10934/
CommitID: c6d6ae2
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-02-09T17:10:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/10933/
CommitID: ad55487

codecov-commenter · 2023-02-09T17:13:33Z

Codecov Report

Merging #6244 (c6d6ae2) into 2.x (9f060b0) will decrease coverage by 0.04%.
The diff coverage is 33.01%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6244      +/-   ##
============================================
- Coverage     70.51%   70.47%   -0.04%     
- Complexity    59080    59116      +36     
============================================
  Files          4778     4785       +7     
  Lines        283188   283484     +296     
  Branches      41232    41259      +27     
============================================
+ Hits         199681   199782     +101     
- Misses        66813    67039     +226     
+ Partials      16694    16663      -31

Impacted Files	Coverage Δ
...es/replication/SegmentReplicationStatsRequest.java	`0.00% <0.00%> (ø)`
...ication/SegmentReplicationStatsRequestBuilder.java	`0.00% <0.00%> (ø)`
.../org/opensearch/client/support/AbstractClient.java	`32.00% <0.00%> (-0.31%)`	⬇️
.../indices/replication/SegmentReplicationSource.java	`100.00% <ø> (ø)`
...cation/TransportSegmentReplicationStatsAction.java	`11.11% <11.11%> (ø)`
...s/replication/SegmentReplicationStatsResponse.java	`13.33% <13.33%> (ø)`
...h/indices/replication/SegmentReplicationState.java	`47.69% <25.35%> (-31.26%)`	⬇️
...s/replication/SegmentReplicationTargetService.java	`50.00% <41.66%> (-0.72%)`	⬇️
...ces/replication/PrimaryShardReplicationSource.java	`96.29% <50.00%> (-3.71%)`	⬇️
...st/action/cat/RestCatSegmentReplicationAction.java	`59.18% <59.18%> (ø)`
... and 486 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

github-actions · 2023-02-09T18:16:12Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

URL: https://build.ci.opensearch.org/job/gradle-check/10945/
CommitID: c6d6ae2
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

kotwanikunal approved these changes Feb 8, 2023

View reviewed changes

Fix compile error.

84a8d3e

Signed-off-by: Rishikesh1159 <[email protected]>

Rishikesh1159 added 2 commits February 9, 2023 16:34

Fix flaky Tests.

ad55487

Signed-off-by: Rishikesh1159 <[email protected]>

Change stability to experimental in cat.segment_replication.json file.

c6d6ae2

Signed-off-by: Rishikesh1159 <[email protected]>

dreamer-89 approved these changes Feb 10, 2023

View reviewed changes

dreamer-89 merged commit d81cd0a into 2.x Feb 10, 2023

github-actions bot deleted the backport/backport-5718-to-2.x branch February 10, 2023 00:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport 2.x] [Segment Replication] Implementing cat/segment_replication API #6244

[Backport 2.x] [Segment Replication] Implementing cat/segment_replication API #6244

opensearch-trigger-bot bot commented Feb 8, 2023

github-actions bot commented Feb 8, 2023

github-actions bot commented Feb 8, 2023

github-actions bot commented Feb 9, 2023

github-actions bot commented Feb 9, 2023

codecov-commenter commented Feb 9, 2023 •

edited

Loading

github-actions bot commented Feb 9, 2023

[Backport 2.x] [Segment Replication] Implementing cat/segment_replication API #6244

[Backport 2.x] [Segment Replication] Implementing cat/segment_replication API #6244

Conversation

opensearch-trigger-bot bot commented Feb 8, 2023

github-actions bot commented Feb 8, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Feb 8, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Feb 9, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Feb 9, 2023

Gradle Check (Jenkins) Run Completed with:

codecov-commenter commented Feb 9, 2023 • edited Loading

Codecov Report

github-actions bot commented Feb 9, 2023

Gradle Check (Jenkins) Run Completed with:

codecov-commenter commented Feb 9, 2023 •

edited

Loading