-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ReplicationFailedException instead of OpensearchException in ReplicationTarget #5955
Merged
dreamer-89
merged 3 commits into
opensearch-project:2.x
from
dreamer-89:backport/backport-4725-to-2.x
Jan 20, 2023
Merged
Use ReplicationFailedException instead of OpensearchException in ReplicationTarget #5955
dreamer-89
merged 3 commits into
opensearch-project:2.x
from
dreamer-89:backport/backport-4725-to-2.x
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamer-89
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
tlfeng,
VachaShah and
xuezhou25
as code owners
January 20, 2023 18:29
dreamer-89
force-pushed
the
backport/backport-4725-to-2.x
branch
from
January 20, 2023 18:31
325d8a8
to
204e800
Compare
Gradle Check (Jenkins) Run Completed with:
|
andrross
reviewed
Jan 20, 2023
mch2
approved these changes
Jan 20, 2023
Gradle Check (Jenkins) Run Completed with:
|
dreamer-89
force-pushed
the
backport/backport-4725-to-2.x
branch
from
January 20, 2023 18:59
204e800
to
9f0df8d
Compare
opensearch-project#4725) * Use ReplicationFailedException instead of OpensearchException in ReplicationTarget Signed-off-by: Ayush Kataria <[email protected]> * CHANGELOG.md updated Signed-off-by: Ayush Kataria <[email protected]> * test fixes Signed-off-by: Ayush Kataria <[email protected]> * spotless fix Signed-off-by: Ayush Kataria <[email protected]> * spotless fix Signed-off-by: Ayush Kataria <[email protected]> * fixes for failing test as suggested in PR comments Signed-off-by: Ayush Kataria <[email protected]> Signed-off-by: Ayush Kataria <[email protected]> Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
dreamer-89
force-pushed
the
backport/backport-4725-to-2.x
branch
from
January 20, 2023 19:01
9f0df8d
to
fde0197
Compare
Signed-off-by: Suraj Singh <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #5955 +/- ##
============================================
- Coverage 70.48% 70.27% -0.22%
+ Complexity 58982 58720 -262
============================================
Files 4766 4766
Lines 282430 282437 +7
Branches 41129 41129
============================================
- Hits 199080 198474 -606
- Misses 66753 67289 +536
- Partials 16597 16674 +77
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6 tasks
kotwanikunal
pushed a commit
that referenced
this pull request
Jan 25, 2023
…icationTarget (#5955) * Use ReplicationFailedException instead of OpensearchException in Repl… (#4725) * Use ReplicationFailedException instead of OpensearchException in ReplicationTarget Signed-off-by: Ayush Kataria <[email protected]> * CHANGELOG.md updated Signed-off-by: Ayush Kataria <[email protected]> * test fixes Signed-off-by: Ayush Kataria <[email protected]> * spotless fix Signed-off-by: Ayush Kataria <[email protected]> * spotless fix Signed-off-by: Ayush Kataria <[email protected]> * fixes for failing test as suggested in PR comments Signed-off-by: Ayush Kataria <[email protected]> Signed-off-by: Ayush Kataria <[email protected]> Signed-off-by: Suraj Singh <[email protected]> * Update SegmentReplicationListener to use ReplicationFailedException Signed-off-by: Suraj Singh <[email protected]> * Spotless fix Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: Ayush Kataria <[email protected]> Signed-off-by: Suraj Singh <[email protected]> Co-authored-by: Ayush Kataria <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to improvement in Segment replication, this change backports #4725 into 2.x