Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReplicationFailedException instead of OpensearchException in ReplicationTarget #5955

Merged

Conversation

dreamer-89
Copy link
Member

Related to improvement in Segment replication, this change backports #4725 into 2.x

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

CHANGELOG.md Show resolved Hide resolved
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

ayushKataria and others added 2 commits January 20, 2023 11:01
opensearch-project#4725)

* Use ReplicationFailedException instead of OpensearchException in ReplicationTarget

Signed-off-by: Ayush Kataria <[email protected]>

* CHANGELOG.md updated

Signed-off-by: Ayush Kataria <[email protected]>

* test fixes

Signed-off-by: Ayush Kataria <[email protected]>

* spotless fix

Signed-off-by: Ayush Kataria <[email protected]>

* spotless fix

Signed-off-by: Ayush Kataria <[email protected]>

* fixes for failing test as suggested in PR comments

Signed-off-by: Ayush Kataria <[email protected]>

Signed-off-by: Ayush Kataria <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
@github-actions

This comment was marked as outdated.

@opensearch-project opensearch-project deleted a comment from github-actions bot Jan 20, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.cluster.service.MasterServiceTests.classMethod
      1 org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes

@codecov-commenter
Copy link

Codecov Report

Merging #5955 (b923712) into 2.x (d51dd7c) will decrease coverage by 0.22%.
The diff coverage is 92.30%.

@@             Coverage Diff              @@
##                2.x    #5955      +/-   ##
============================================
- Coverage     70.48%   70.27%   -0.22%     
+ Complexity    58982    58720     -262     
============================================
  Files          4766     4766              
  Lines        282430   282437       +7     
  Branches      41129    41129              
============================================
- Hits         199080   198474     -606     
- Misses        66753    67289     +536     
- Partials      16597    16674      +77     
Impacted Files Coverage Δ
...ch/indices/cluster/IndicesClusterStateService.java 66.23% <ø> (-2.08%) ⬇️
...arch/indices/recovery/RecoveryFailedException.java 100.00% <ø> (ø)
.../opensearch/indices/recovery/RecoveryListener.java 100.00% <ø> (ø)
...rg/opensearch/indices/recovery/RecoveryTarget.java 72.94% <ø> (ø)
...ices/replication/common/ReplicationCollection.java 74.07% <0.00%> (+0.92%) ⬆️
...org/opensearch/index/shard/IndexShardTestCase.java 94.25% <ø> (ø)
.../indices/replication/SegmentReplicationTarget.java 91.26% <100.00%> (-0.09%) ⬇️
...s/replication/SegmentReplicationTargetService.java 62.85% <100.00%> (+0.72%) ⬆️
...replication/common/ReplicationFailedException.java 100.00% <100.00%> (+87.50%) ⬆️
.../indices/replication/common/ReplicationTarget.java 77.33% <100.00%> (-6.67%) ⬇️
... and 529 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dreamer-89 dreamer-89 merged commit a25c6b7 into opensearch-project:2.x Jan 20, 2023
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
…icationTarget (#5955)

* Use ReplicationFailedException instead of OpensearchException in Repl… (#4725)

* Use ReplicationFailedException instead of OpensearchException in ReplicationTarget

Signed-off-by: Ayush Kataria <[email protected]>

* CHANGELOG.md updated

Signed-off-by: Ayush Kataria <[email protected]>

* test fixes

Signed-off-by: Ayush Kataria <[email protected]>

* spotless fix

Signed-off-by: Ayush Kataria <[email protected]>

* spotless fix

Signed-off-by: Ayush Kataria <[email protected]>

* fixes for failing test as suggested in PR comments

Signed-off-by: Ayush Kataria <[email protected]>

Signed-off-by: Ayush Kataria <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>

* Update SegmentReplicationListener to use ReplicationFailedException

Signed-off-by: Suraj Singh <[email protected]>

* Spotless fix

Signed-off-by: Suraj Singh <[email protected]>

Signed-off-by: Ayush Kataria <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
Co-authored-by: Ayush Kataria <[email protected]>
@dreamer-89 dreamer-89 deleted the backport/backport-4725-to-2.x branch March 2, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants