Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segment Replication] Mute flaky tests #5739

Merged
merged 1 commit into from
Jan 6, 2023
Merged

[Segment Replication] Mute flaky tests #5739

merged 1 commit into from
Jan 6, 2023

Conversation

dreamer-89
Copy link
Member

Description

Revealed in #5737, muting flaky test.

Issues Resolved

NA

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5739 (5fa59aa) into main (6c7586c) will decrease coverage by 0.00%.
The diff coverage is 42.66%.

❗ Current head 5fa59aa differs from pull request most recent head 97254b8. Consider uploading reports for the commit 97254b8 to get more accurate results

@@             Coverage Diff              @@
##               main    #5739      +/-   ##
============================================
- Coverage     71.00%   71.00%   -0.01%     
- Complexity    58659    58756      +97     
============================================
  Files          4766     4767       +1     
  Lines        280030   280149     +119     
  Branches      40434    40443       +9     
============================================
+ Hits         198838   198918      +80     
- Misses        64911    65061     +150     
+ Partials      16281    16170     -111
Impacted Files Coverage Δ
.../opensearch/gradle/plugin/PluginBuildPlugin.groovy 36.28% <0.00%> (ø)
...rg/opensearch/common/settings/ClusterSettings.java 91.89% <ø> (ø)
.../opensearch/indices/recovery/ForceSyncRequest.java 0.00% <0.00%> (ø)
.../recovery/LocalStorePeerRecoverySourceHandler.java 80.45% <ø> (-0.23%) ⬇️
...rg/opensearch/indices/recovery/RecoveryTarget.java 73.41% <0.00%> (-3.02%) ⬇️
...search/indices/recovery/RecoveryTargetHandler.java 100.00% <ø> (ø)
.../indices/recovery/RemoteRecoveryTargetHandler.java 89.55% <0.00%> (-10.45%) ⬇️
server/src/main/java/org/opensearch/node/Node.java 87.17% <ø> (ø)
...ation/OpenSearchIndexLevelReplicationTestCase.java 89.67% <0.00%> (-0.20%) ⬇️
...a/org/opensearch/test/OpenSearchIntegTestCase.java 55.14% <0.00%> (-1.88%) ⬇️
... and 470 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation

@dreamer-89 dreamer-89 merged commit 4a62341 into opensearch-project:main Jan 6, 2023
@dreamer-89 dreamer-89 mentioned this pull request Jan 7, 2023
Merged
6 tasks
mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Jan 19, 2023
@dreamer-89 @mch2
[Segment Replication] Mute flaky tests (opensearch-project#5739)
4915d02 
Signed-off-by: Suraj Singh <[email protected]>

Signed-off-by: Suraj Singh <[email protected]>
dreamer-89 added a commit that referenced this pull request Jan 20, 2023
@mch2 @dreamer-89
[Backport 2.x] Backport SegmentReplication test muting missing from 2…
37f5c22 
….x. (#5945)

* [Segment Replication] Add snapshot and restore tests for segment replication feature (#3993)

* [Segment Replication] Add snapshots tests with segment replication enabled

Signed-off-by: Suraj Singh <[email protected]>

* Fix spotless failures

Signed-off-by: Suraj Singh <[email protected]>

* Add changelog entry, address review comments, add failover test

Signed-off-by: Suraj Singh <[email protected]>

* Fix spotless failures

Signed-off-by: Suraj Singh <[email protected]>

* Address review comments 2

Signed-off-by: Suraj Singh <[email protected]>

Signed-off-by: Suraj Singh <[email protected]>

* Remove changelog update.

Signed-off-by: Marc Handalian <[email protected]>

* Mute flaky test testStartReplicaAfterPrimaryIndexesDocs. (#5714)

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Marc Handalian <[email protected]>

* Fix flaky Segment Replication test testStartReplicaAfterPrimaryIndexesDocs. (#5722)

* Fix flaky SR test testStartReplicaAfterPrimaryIndexesDocs.

This test was failing because we are validating post recovery if a shard is able to perform segrep while also performing validation if a passed in checkopint.  In the post recovery test this checkpoint is always empty, yet the shard will be ahead of this checkpoint after docs are indexed.  This change differentiates shard validation from checkpoint validation.

Signed-off-by: Marc Handalian <[email protected]>

Fix spotless.

Signed-off-by: Marc Handalian <[email protected]>

Fix testIsSegmentReplicationAllowed_WrongEngineType.

Signed-off-by: Marc Handalian <[email protected]>

Update warn logs in isSegmentReplicationAllowed.

Signed-off-by: Marc Handalian <[email protected]>

* PR feedback.

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Marc Handalian <[email protected]>

* [Segment Replication] Mute flaky tests (#5739)

Signed-off-by: Suraj Singh <[email protected]>

Signed-off-by: Suraj Singh <[email protected]>

* [Segment Replication] Mute flaky tests (#5742)

Signed-off-by: Suraj Singh <[email protected]>

Signed-off-by: Suraj Singh <[email protected]>

* Fix spotless.

Signed-off-by: Marc Handalian <[email protected]>

* Muting flaky SegmentReplication ITs. (#5700)

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Marc Handalian <[email protected]>
Co-authored-by: Suraj Singh <[email protected]>
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
@mch2 @dreamer-89 @kotwanikunal
[Backport 2.x] Backport SegmentReplication test muting missing from 2…
51f7ea0 
….x. (#5945)

* [Segment Replication] Add snapshot and restore tests for segment replication feature (#3993)

* [Segment Replication] Add snapshots tests with segment replication enabled

Signed-off-by: Suraj Singh <[email protected]>

* Fix spotless failures

Signed-off-by: Suraj Singh <[email protected]>

* Add changelog entry, address review comments, add failover test

Signed-off-by: Suraj Singh <[email protected]>

* Fix spotless failures

Signed-off-by: Suraj Singh <[email protected]>

* Address review comments 2

Signed-off-by: Suraj Singh <[email protected]>

Signed-off-by: Suraj Singh <[email protected]>

* Remove changelog update.

Signed-off-by: Marc Handalian <[email protected]>

* Mute flaky test testStartReplicaAfterPrimaryIndexesDocs. (#5714)

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Marc Handalian <[email protected]>

* Fix flaky Segment Replication test testStartReplicaAfterPrimaryIndexesDocs. (#5722)

* Fix flaky SR test testStartReplicaAfterPrimaryIndexesDocs.

This test was failing because we are validating post recovery if a shard is able to perform segrep while also performing validation if a passed in checkopint.  In the post recovery test this checkpoint is always empty, yet the shard will be ahead of this checkpoint after docs are indexed.  This change differentiates shard validation from checkpoint validation.

Signed-off-by: Marc Handalian <[email protected]>

Fix spotless.

Signed-off-by: Marc Handalian <[email protected]>

Fix testIsSegmentReplicationAllowed_WrongEngineType.

Signed-off-by: Marc Handalian <[email protected]>

Update warn logs in isSegmentReplicationAllowed.

Signed-off-by: Marc Handalian <[email protected]>

* PR feedback.

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Marc Handalian <[email protected]>

* [Segment Replication] Mute flaky tests (#5739)

Signed-off-by: Suraj Singh <[email protected]>

Signed-off-by: Suraj Singh <[email protected]>

* [Segment Replication] Mute flaky tests (#5742)

Signed-off-by: Suraj Singh <[email protected]>

Signed-off-by: Suraj Singh <[email protected]>

* Fix spotless.

Signed-off-by: Marc Handalian <[email protected]>

* Muting flaky SegmentReplication ITs. (#5700)

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Marc Handalian <[email protected]>

Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Marc Handalian <[email protected]>
Co-authored-by: Suraj Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mch2 mch2 mch2 approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@adnapibar adnapibar Awaiting requested review from adnapibar

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@xuezhou25 xuezhou25 Awaiting requested review from xuezhou25

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamer-89 @codecov-commenter @mch2