Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Remove PRRL creation/deletion in peer recovery of remote store enabled replica (#4954) #5728

Closed
wants to merge 1 commit into from

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Jan 6, 2023

Description

Original PR - #4954

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashking94 ashking94 changed the title Remove PRRL creation/deletion in peer recovery of remote store enabled replica [Backport 2.x] Remove PRRL creation/deletion in peer recovery of remote store enabled replica (#4954) Jan 6, 2023
…d replica (opensearch-project#4954)

* Add RecoverySourceHandlerFactory for extensibility

Signed-off-by: Ashish Singh <[email protected]>

* recoverToTarget made extensible to allow multiple implementations

Signed-off-by: Ashish Singh <[email protected]>

* Remove PRRL after SendFileStep in Peer Recovery

Signed-off-by: Ashish Singh <[email protected]>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <[email protected]>

* Empty-Commit

Signed-off-by: Ashish Singh <[email protected]>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <[email protected]>

* Empty-Commit

Signed-off-by: Ashish Singh <[email protected]>

* Empty-Commit

Signed-off-by: Ashish Singh <[email protected]>

* Remove CHANGELOG entry as this is incremental PR

Signed-off-by: Ashish Singh <[email protected]>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <[email protected]>

Signed-off-by: Ashish Singh <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5728 (b1936ac) into 2.x (85b85b1) will increase coverage by 0.11%.
The diff coverage is 82.96%.

@@             Coverage Diff              @@
##                2.x    #5728      +/-   ##
============================================
+ Coverage     70.53%   70.64%   +0.11%     
- Complexity    58612    58681      +69     
============================================
  Files          4741     4744       +3     
  Lines        280588   280632      +44     
  Branches      40894    40895       +1     
============================================
+ Hits         197918   198258     +340     
+ Misses        66152    65843     -309     
- Partials      16518    16531      +13     
Impacted Files Coverage Δ
...recovery/RemoteStorePeerRecoverySourceHandler.java 77.77% <77.77%> (ø)
.../recovery/LocalStorePeerRecoverySourceHandler.java 80.68% <80.68%> (ø)
...search/indices/recovery/RecoverySourceHandler.java 77.46% <84.84%> (+0.85%) ⬆️
...indices/recovery/RecoverySourceHandlerFactory.java 92.30% <92.30%> (ø)
...org/opensearch/index/seqno/ReplicationTracker.java 68.13% <100.00%> (-0.17%) ⬇️
...ch/indices/recovery/PeerRecoverySourceService.java 59.74% <100.00%> (+3.41%) ⬆️
...org/opensearch/index/shard/IndexShardTestCase.java 93.79% <100.00%> (-0.18%) ⬇️
...a/org/opensearch/client/cluster/SniffModeInfo.java 0.00% <0.00%> (-62.50%) ⬇️
...a/org/opensearch/tasks/TaskCancelledException.java 50.00% <0.00%> (-50.00%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-44.45%) ⬇️
... and 494 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashking94 ashking94 closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants