Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows failure on InternalDistributionArchiveSetupPluginFuncTest #5427

Merged

Conversation

Poojita-Raj
Copy link
Contributor

Signed-off-by: Poojita Raj [email protected]

Description

Failure on windows for the InternalDistributionArchiveSetupPluginFuncTest is unexpected. Fails with "registered distribution provides archives and directory variant".
This is because -

tar task execution is skipped on windows.
plain copy task execution doesn't execute on windows since source files will not be present.

To get the test passing again, we check for expected conditions on windows and non-windows machines.

Issues Resolved

Resolves #5324

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5427 (d2edf76) into 1.3 (c0b5237) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3    #5427      +/-   ##
============================================
- Coverage     77.95%   77.89%   -0.07%     
+ Complexity    63473    63417      -56     
============================================
  Files          4454     4454              
  Lines        274943   274943              
  Branches      41166    41166              
============================================
- Hits         214333   214158     -175     
- Misses        43708    43865     +157     
- Partials      16902    16920      +18     
Impacted Files Coverage Δ
...a/org/opensearch/client/cluster/ProxyModeInfo.java 0.00% <0.00%> (-57.90%) ⬇️
...ch/index/shard/ShardNotInPrimaryModeException.java 50.00% <0.00%> (-50.00%) ⬇️
...org/opensearch/indices/IndexCreationException.java 60.00% <0.00%> (-40.00%) ⬇️
...h/script/mustache/MultiSearchTemplateResponse.java 56.25% <0.00%> (-31.25%) ⬇️
.../java/org/opensearch/index/merge/OnGoingMerge.java 71.42% <0.00%> (-28.58%) ⬇️
...rc/main/java/org/opensearch/ingest/IngestInfo.java 51.72% <0.00%> (-27.59%) ⬇️
...ava/org/opensearch/OpenSearchTimeoutException.java 50.00% <0.00%> (-25.00%) ⬇️
...aggregations/support/values/ScriptBytesValues.java 69.44% <0.00%> (-25.00%) ⬇️
...min/cluster/tasks/PendingClusterTasksResponse.java 35.00% <0.00%> (-25.00%) ⬇️
.../opensearch/transport/ProxyConnectionStrategy.java 62.12% <0.00%> (-23.49%) ⬇️
... and 465 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Poojita-Raj Poojita-Raj merged commit 229149c into opensearch-project:1.3 Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants