Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for windows failure InternalDistributionArchiveSetupPluginFuncTest #5413

Conversation

Poojita-Raj
Copy link
Contributor

Description

Failure on windows for the InternalDistributionArchiveSetupPluginFuncTest is unexpected. Fails with "registered distribution provides archives and directory variant".
This is because -

  • tar task execution is skipped on windows.
  • plain copy task execution doesn't execute on windows since source files will not be present.
    To get the test passing again, we check for expected conditions on windows and non-windows machines.

Issues Resolved

Resolves #5324

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Poojita-Raj Poojita-Raj requested review from a team and reta as code owners November 30, 2022 19:16
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant