-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for JDK version while setting java.security.manager option #5205
Merged
adnapibar
merged 2 commits into
opensearch-project:main
from
adnapibar:jsm-option-allow
Nov 10, 2022
Merged
Check for JDK version while setting java.security.manager option #5205
adnapibar
merged 2 commits into
opensearch-project:main
from
adnapibar:jsm-option-allow
Nov 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
requested changes
Nov 10, 2022
buildSrc/src/main/java/org/opensearch/gradle/OpenSearchTestBasePlugin.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rabi Panda <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rabi Panda <[email protected]>
3 tasks
I'm pretty sure we need this check, seeing the following in security builds on JDK11
|
peternied
approved these changes
Nov 10, 2022
reta
approved these changes
Nov 10, 2022
🤞 Go Gradle check go! |
Gradle Check (Jenkins) Run Completed with:
|
reta
pushed a commit
to reta/OpenSearch
that referenced
this pull request
Oct 30, 2023
…nsearch-project#5205) Signed-off-by: Rabi Panda <[email protected]>
reta
pushed a commit
to reta/OpenSearch
that referenced
this pull request
Nov 10, 2023
…nsearch-project#5205) Signed-off-by: Rabi Panda <[email protected]>
reta
added a commit
that referenced
this pull request
Nov 14, 2023
* Update bundled JDK to JDK-21.0.1 (#10576) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 0d7d1e9) Signed-off-by: Andriy Redko <[email protected]> * Add condition to check JVM version for illegal-access switch (#5279) This switch is removed in JDK version 17. https://openjdk.org/jeps/403 Signed-off-by: Rabi Panda <[email protected]> * Check for JDK version while setting java.security.manager option (#5205) Signed-off-by: Rabi Panda <[email protected]> * Fix tests and test skaffolding Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Rabi Panda <[email protected]> Co-authored-by: Rabi Panda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rabi Panda [email protected]
Description
This updates #5194 to check for JDK versions before setting the option.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.