Allow mmap to use new preview JDK-19 APIs in Apache Lucene 9.4+ #5151
Conversation
Gradle Check (Jenkins) Run Completed with:
|
CHANGELOG.md
Outdated
| @@ -135,6 +135,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Fail weight update when decommission ongoing and fail decommission when attribute not weighed away ([#4839](https://github.com/opensearch-project/OpenSearch/pull/4839)) | |||
| - Skip SymbolicLinkPreservingTarIT when running on Windows ([#5023](https://github.com/opensearch-project/OpenSearch/pull/5023)) | |||
| - Change the output error message back to use OpenSearchException in the cause chain. ([#5081](https://github.com/opensearch-project/OpenSearch/pull/5081)) | |||
| - Allow mmap to use new preview JDK-19 APIs in Apache Lucene 9.4+ ([#5151](https://github.com/opensearch-project/OpenSearch/pull/5151)) | |||
There was a problem hiding this comment.
We just pushed an update to the changelog policy that applies the learnings from the recent 2.4 release.
This is probably an example that can skip the changelog? Whatever changes make use of the new APIs would be relevant, but this is probably too low level.
There was a problem hiding this comment.
Thanks @andrross , I could be mistaken but it falls into A newly added feature: we activate a new Apache Lucene feature by changing the JVM parameters, what do you think from this perspective? (I am fine removing changelog line as well)
There was a problem hiding this comment.
Ah, does Lucene detect this setting and change its behavior at runtime accordingly? If so then you're right :)
I should have read the description more carefully. You're right this is a newly added feature.
Gradle Check (Jenkins) Run Completed with:
|
reta
force-pushed
the
allow.preview
branch
2 times, most recently
from
2869696
to
f381e50
Compare
Signed-off-by: Andriy Redko <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
|
Technically the preview feature would only work with exactly java 19. But it won't hurt if you pass it with 20. Lucenes will ignore it. |
Thanks @uschindler , I started with |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Andriy Redko <[email protected]>
| javadoc.options.addBooleanOption("-enable-preview", true) | ||
| javadoc.options.addStringOption("-release", BuildParams.runtimeJavaVersion.majorVersion) | ||
| } | ||
| javadoc.options.addStringOption("-release", targetCompatibility.majorVersion) |
There was a problem hiding this comment.
Align javadoc release with target compatibility settings
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5151 +/- ##
============================================
+ Coverage 70.84% 70.94% +0.09%
- Complexity 57867 58141 +274
============================================
Files 4692 4708 +16
Lines 276650 277557 +907
Branches 40155 40188 +33
============================================
+ Hits 196002 196921 +919
+ Misses 64500 64482 -18
- Partials 16148 16154 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Andriy Redko [email protected]
Description
Allow mmap to use new preview JDK-19 APIs in Apache Lucene 9.4+. When
--enable-previewis not present:With
--enable-preview:Issues Resolved
Final part of #4637
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.