[Remove] Version.V_1_ constants #5021

nknize · 2022-11-01T18:52:47Z

Removes all usages of OpenSearch Version.V_1_ version constants along with unused API logic.

github-actions · 2022-11-01T19:16:42Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6098/
CommitID: 17db2de
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-01T19:18:12Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6099/
CommitID: 9fa3ff4
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-01T20:15:02Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6114/
CommitID: 6f15d24
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-01T20:30:13Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6120/
CommitID: 36019a2
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-01T21:28:51Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/6138/
CommitID: 3ca93be

github-actions · 2022-11-02T14:35:49Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/6206/
CommitID: 6d10f49

github-actions · 2022-11-02T14:45:33Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/6208/
CommitID: 06177bd

Removes all usages of Version.V_1_ version constants along with ancient API logic. Signed-off-by: Nicholas Walter Knize <[email protected]>

Signed-off-by: Nicholas Walter Knize <[email protected]>

github-actions · 2022-11-02T18:59:29Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/6239/
CommitID: 7edea63

dblock · 2022-11-02T19:33:54Z

client/rest-high-level/src/test/java/org/opensearch/client/core/MainResponseTests.java

@@ -46,21 +46,16 @@
 import static org.hamcrest.Matchers.equalTo;

 public class MainResponseTests extends AbstractResponseTestCase<org.opensearch.action.main.MainResponse, MainResponse> {
+    private static String DISTRIBUTION = "opensearch";


Nit: seems unnecessary, just hard-code "opensearch" in the one place below.

dblock · 2022-11-02T19:38:47Z

server/src/main/java/org/opensearch/transport/TransportHandshaker.java

-                minCompatVersion = Version.fromId(6079999);
-            } else if (version.before(Version.V_3_0_0)) {
-                minCompatVersion = Version.fromId(7099999);
-            }


What happens when an ES tries to connect to OpenSearch 3.x after this?

This PR addresses AD compile failure because the core removed 1x Version constants. (check opensearch-project/OpenSearch#5021) OpenSearch does not support N-2 version compatibility. This is inherited from Elasticsearch and Lucene. So version 1x is not compatible with 3.0. Thus removal of deprecated 1x code. This PR follows suite and removes backward compatibility code on OpenSearch 1.0 and older versions. So we won't support direct upgrade from 1.x domains to 3.x. Testing done: 1. gradle build. Note that CI workflow will fail due to missing job scheduler. We are using a job scheduler from distribution. But due to a circular dependency on -SNAPSHOT builds being published to maven that require the distribution build to be successful (check opensearch-project/opensearch-build#1463), AD compilation failure caused the job scheduler to be taken out. Not including the latest job scheduler will cause AD build to fail. So we have a chicken and egg problem: this PR fixes AD build failure and the PR itself cannot build due to missing job scheduler. To run gradle build, I changed to use local job scheduler and verified gradle build succeeded. Once I merge this PR. job scheduler should be able to build and be published to maven. Future AD CI should be unblocked after that.

This PR addresses AD compile failure because the core removed 1x Version constants. (check opensearch-project/OpenSearch#5021) OpenSearch does not support N-2 version compatibility. This is inherited from Elasticsearch and Lucene. So version 1x is not compatible with 3.0. Thus removal of deprecated 1x code. This PR follows suite and removes backward compatibility code on OpenSearch 1.0 and older versions. So we won't support direct upgrade from 1.x domains to 3.x. Testing done: 1. gradle build. Note that CI workflow will fail due to missing job scheduler. We are using a job scheduler from distribution. But due to a circular dependency on -SNAPSHOT builds being published to maven that require the distribution build to be successful (check opensearch-project/opensearch-build#1463), AD compilation failure caused the job scheduler to be taken out. Not including the latest job scheduler will cause AD build to fail. So we have a chicken and egg problem: this PR fixes AD build failure and the PR itself cannot build due to missing job scheduler. To run gradle build, I changed to use local job scheduler and verified gradle build succeeded. Once I merge this PR. job scheduler should be able to build and be published to maven. Future AD CI should be unblocked after that. Signed-off-by: Kaituo Li <[email protected]>

nknize added non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v3.0.0 Issues and PRs related to version 3.0.0 labels Nov 1, 2022

nknize requested review from a team and reta as code owners November 1, 2022 18:52

nknize force-pushed the remove/1112VersionConstants branch from 3ca93be to 6d10f49 Compare November 2, 2022 13:57

nknize added 7 commits November 2, 2022 13:23

[Remove] Version.V_1_ constants

0948ff6

Removes all usages of Version.V_1_ version constants along with ancient API logic. Signed-off-by: Nicholas Walter Knize <[email protected]>

update changelog

95bf20f

Signed-off-by: Nicholas Walter Knize <[email protected]>

retain version utils version 1 check

3b308e2

Signed-off-by: Nicholas Walter Knize <[email protected]>

remove v1 test from mincompat testing

c4d25ee

Signed-off-by: Nicholas Walter Knize <[email protected]>

fix versions and remove bwc test from pluginsInfoTests

bb33a08

Signed-off-by: Nicholas Walter Knize <[email protected]>

remove unused es warning check

bd7a23f

Signed-off-by: Nicholas Walter Knize <[email protected]>

improve legibility of removed v1 constant

7edea63

Signed-off-by: Nicholas Walter Knize <[email protected]>

nknize force-pushed the remove/1112VersionConstants branch from 06177bd to 7edea63 Compare November 2, 2022 18:25

dblock approved these changes Nov 2, 2022

View reviewed changes

dblock merged commit 8bbb194 into opensearch-project:main Nov 2, 2022

kaituo mentioned this pull request Nov 4, 2022

remove bwc code related to 1.0 and earlier version opensearch-project/anomaly-detection#714

Merged

This was referenced Nov 11, 2022

[BUG] Remove bwc code related to 1.0 and earlier version opensearch-project/opensearch-sdk-java#242

Closed

[Feature/extensions] Removed BWC code for 1.0 version opensearch-project/anomaly-detection#727

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Remove] Version.V_1_ constants #5021

[Remove] Version.V_1_ constants #5021

nknize commented Nov 1, 2022

github-actions bot commented Nov 1, 2022

github-actions bot commented Nov 1, 2022

github-actions bot commented Nov 1, 2022

github-actions bot commented Nov 1, 2022

github-actions bot commented Nov 1, 2022

github-actions bot commented Nov 2, 2022

github-actions bot commented Nov 2, 2022

github-actions bot commented Nov 2, 2022

dblock Nov 2, 2022

dblock Nov 2, 2022

[Remove] Version.V_1_ constants #5021

[Remove] Version.V_1_ constants #5021

Conversation

nknize commented Nov 1, 2022

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 1, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 2, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 2, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 2, 2022

Gradle Check (Jenkins) Run Completed with:

dblock Nov 2, 2022

Choose a reason for hiding this comment

dblock Nov 2, 2022

Choose a reason for hiding this comment