Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove] Deprecated serialization logic from pipeline aggs #4847

Merged
merged 3 commits into from
Oct 20, 2022
Merged

[Remove] Deprecated serialization logic from pipeline aggs #4847

merged 3 commits into from
Oct 20, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Oct 20, 2022

Removes the deprecated readTo/writeFrom serialization logic from piepline aggs that is no longer used as of Legacy version 7.8.

@nknize nknize added non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0 labels Oct 20, 2022
@nknize nknize requested review from a team and reta as code owners October 20, 2022 13:27
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
[Remove] Deprecated serialization logic from pipeline aggs
1db3612 
Removes the deprecated readTo/writeFrom serialization logic from piepline aggs
that is no longer used as of Legacy version 7.8.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize
update changelog
ed1944f 
Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize force-pushed the remove/deprecatedPipelineAggSerializations branch from 4daebc8 to ed1944f Compare October 20, 2022 13:44
@nknize
rebase
75a0ddb 
Signed-off-by: Nicholas Walter Knize <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@adnapibar adnapibar mentioned this pull request Oct 20, 2022
Open
19 tasks
adnapibar
adnapibar approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nknize nknize merged commit 515f84b into opensearch-project:main Oct 20, 2022
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Nov 7, 2022
@nknize @ashking94
[Remove] Deprecated serialization logic from pipeline aggs (opensearc…
bc57fe3 
…h-project#4847)

Removes the deprecated readTo/writeFrom serialization logic from piepline aggs
that is no longer used as of Legacy version 7.8.

Signed-off-by: Nicholas Walter Knize <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnapibar adnapibar adnapibar approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

Assignees
No one assigned
Labels
non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nknize @adnapibar