Fail weight update when decommission ongoing and fail decommission when attribute not weighed away #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishab Nahata <[email protected]>
Signed-off-by: Rishab Nahata <[email protected]>
Signed-off-by: Rishab Nahata <[email protected]>
imRishN
changed the title
Signed-off-by: Rishab Nahata <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
reviewed
Oct 19, 2022
| WeightedRouting weightedRouting = weightedRoutingMetadata.getWeightedRouting(); | ||
| if (weightedRouting.attributeName().equals(decommissionAttribute.attributeName())) { | ||
| Double attributeValueWeight = weightedRouting.weights().get(decommissionAttribute.attributeValue()); | ||
| if (attributeValueWeight == null || attributeValueWeight != 0.0) { |
There was a problem hiding this comment.
is this value float or double, should we make specific comparisons. For instance Double.valueOf(0.0)
There was a problem hiding this comment.
It is Double. using .equals()
Bukhtawar
reviewed
Oct 19, 2022
server/src/main/java/org/opensearch/cluster/decommission/DecommissionService.java
Outdated
Show resolved
Hide resolved
Bukhtawar
reviewed
Oct 19, 2022
server/src/main/java/org/opensearch/cluster/routing/WeightedRoutingService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rishab Nahata <[email protected]>
Fix spotless check Signed-off-by: Rishab Nahata <[email protected]>
imRishN
force-pushed
the
wrr-validation
branch
from
494a7a0
to
05eb55a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rishab Nahata <[email protected]>
6 tasks
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4839 +/- ##
============================================
- Coverage 70.73% 70.70% -0.03%
- Complexity 57884 57894 +10
============================================
Files 4689 4689
Lines 277296 277314 +18
Branches 40363 40367 +4
============================================
- Hits 196137 196075 -62
- Misses 64873 64968 +95
+ Partials 16286 16271 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sachinpkale
reviewed
Oct 20, 2022
|
|
||
| public void ensureNoOngoingDecommissionAction(ClusterState state) { | ||
| DecommissionAttributeMetadata decommissionAttributeMetadata = state.metadata().decommissionAttributeMetadata(); | ||
| if (decommissionAttributeMetadata != null && decommissionAttributeMetadata.status().equals(DecommissionStatus.FAILED) == false) { |
There was a problem hiding this comment.
What if status is SUCCESSFUL?
There was a problem hiding this comment.
Only when Decommission has failed, we can allow the weight update can go through. Not for any other status
There was a problem hiding this comment.
Isn't SUCCESSFUL a final state? The error message of this if condition says: a decommission action is ongoing with status...
There was a problem hiding this comment.
A succesful decommission state means the transport execution has completed. The nodes are decommissioned in this state (not able to start pre voting or join). Hence DecommissionAction ongoing means a zone is decommissioned and the cluster rejects pings from decommissioned node
|
Build is failing, please fix the build. |
Bukhtawar
reviewed
Oct 20, 2022
|
|
||
| public void ensureNoOngoingDecommissionAction(ClusterState state) { | ||
| DecommissionAttributeMetadata decommissionAttributeMetadata = state.metadata().decommissionAttributeMetadata(); | ||
| if (decommissionAttributeMetadata != null && decommissionAttributeMetadata.status().equals(DecommissionStatus.FAILED) == false) { |
There was a problem hiding this comment.
If decommission status is FAILED can certain nodes be out of service or decommissioned while others not as in partially failed?
There was a problem hiding this comment.
No, if the decommission is FAILED, joins or prevoting is not blocked on those nodes and hence if some nodes are out of service (which can happen), the weights request can go through
There was a problem hiding this comment.
But then the zone isn't fully equipped to take traffic right like 90% nodes are out of service and we place weights 10:1:1 when 10 is for the zone only operating at 10% capacity?
Bukhtawar
approved these changes
Oct 20, 2022
Signed-off-by: Rishab Nahata <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
sachinpkale
approved these changes
Oct 20, 2022
imRishN
added a commit
to imRishN/OpenSearch
that referenced
this pull request
Nov 3, 2022
…en attribute not weighed away (opensearch-project#4839) * Add checks for decommission before setting weights Signed-off-by: Rishab Nahata <[email protected]>
6 tasks
Bukhtawar
pushed a commit
that referenced
this pull request
Nov 3, 2022
* Fail weight update when decommission ongoing and fail decommission when attribute not weighed away (#4839) * Add changes for graceful node decommission (#4586) * Add delay timeout for decommission request (#4931) * Integ Tests for Awareness Attribute Decommissioning (#4715) Signed-off-by: Rishab Nahata <[email protected]> Signed-off-by: pranikum <[email protected]>
imRishN
added a commit
to imRishN/OpenSearch
that referenced
this pull request
Nov 3, 2022
* Fail weight update when decommission ongoing and fail decommission when attribute not weighed away (opensearch-project#4839) * Add changes for graceful node decommission (opensearch-project#4586) * Add delay timeout for decommission request (opensearch-project#4931) * Integ Tests for Awareness Attribute Decommissioning (opensearch-project#4715) Signed-off-by: Rishab Nahata <[email protected]> Signed-off-by: pranikum <[email protected]>
ashking94
pushed a commit
to ashking94/OpenSearch
that referenced
this pull request
Nov 7, 2022
…en attribute not weighed away (opensearch-project#4839) * Add checks for decommission before setting weights Signed-off-by: Rishab Nahata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#4838
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.