[Feature/Identity] Allow for Encryption/Decryption of Principals into PITs #4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
stephen-crawford
requested review from
cwperks,
peternied and
DarshitChanpura
Gradle Check (Jenkins) Run Completed with:
|
|
@scrawfor99 Can you prepend the title of this PR with |
cwperks
reviewed
Oct 11, 2022
server/src/main/java/org/opensearch/identity/ExtensionTokenProcessor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
stephen-crawford
changed the title
Should be all set |
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
cwperks
requested changes
Oct 11, 2022
server/src/main/java/org/opensearch/identity/ExtensionTokenProcessor.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/identity/ExtensionTokenProcessor.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/identity/ExtensionTokenProcessor.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/identity/ExtensionTokenProcessor.java
Outdated
Show resolved
Hide resolved
Oops I did not realize but will mark things as such in the future--still new to using GitHub with more than 1/2 other people haha. |
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
@peternied What is the protocol for handling this? Everything seems fine on my end but now the check is failing because of memory errors from other code. Unless I am misunderstanding the console output. |
Sounds like there is as bug in OpenSearch, can you capture the error output and create a bug like the following? |
Done so awaiting response #4907 |
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
@scrawfor99 I merged this because the failed tests are unrelated to your changes. Next merge from main should resolve them (also what a pain!) Thanks for your contribution and stick-with-it-ness on this one! |
peternied
pushed a commit
that referenced
this pull request
Nov 2, 2022
… PITs (#4730) Allow for Encryption/Decryption of Principals into PITs Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the ExtensionTokenProcessor class to allow for encryption & decryption of principal & extension identifiers.
Tests not yet added but will add unit tests. Right now there are some lingering issues with the code that I would appreciate feedback or thoughts on:
As you can see at Line 146, the ExtractPrincipal method attempts to return the Principal object that is extracted from the encrypted message. Right now, I am not sure that we are actually storing the Principals themselves in any way so to be able to return an entire Principal instance we would need to be able to store and then retrieve the instance via NAME lookup.
I am also not entirely convinced by my implementation of the encoding combining at Line 106. I know you can combine byte[]s in this manner but I have not had a chance to confirm this preserves the encoding integrity as expected.
Resolves
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.