-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/extensions] Warn future developers not to pass headers to extensions #4430
[Feature/extensions] Warn future developers not to pass headers to extensions #4430
Conversation
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "here there be dragons" would be a more fun comment, but this one suffices.
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
1a8a26e
to
039ad26
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## feature/extensions #4430 +/- ##
========================================================
- Coverage 70.61% 70.59% -0.03%
+ Complexity 57436 57416 -20
========================================================
Files 4641 4641
Lines 276249 276249
Branches 40384 40384
========================================================
- Hits 195083 195016 -67
- Misses 64847 64930 +83
+ Partials 16319 16303 -16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@opensearch-project/security What do you folks think, is this a worthwhile stopgap measure? |
Description
Warn future developers not to pass headers to extensions
Issues Resolved
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)Note; I did not include any change log changes because I don't see a change log in this branchBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.