Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/extensions] Warn future developers not to pass headers to extensions #4430

Merged

Conversation

peternied
Copy link
Member

@peternied peternied commented Sep 6, 2022

Description

Warn future developers not to pass headers to extensions

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog) Note; I did not include any change log changes because I don't see a change log in this branch

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Gradle Check (Jenkins) Run Completed with:

@owaiskazi19 owaiskazi19 changed the title Warn future developers not to pass headers to extensions [Feature/extensions] Warn future developers not to pass headers to extensions Sep 7, 2022
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "here there be dragons" would be a more fun comment, but this one suffices.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4430 (039ad26) into feature/extensions (14b899b) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             feature/extensions    #4430      +/-   ##
========================================================
- Coverage                 70.61%   70.59%   -0.03%     
+ Complexity                57436    57416      -20     
========================================================
  Files                      4641     4641              
  Lines                    276249   276249              
  Branches                  40384    40384              
========================================================
- Hits                     195083   195016      -67     
- Misses                    64847    64930      +83     
+ Partials                  16319    16303      -16     
Impacted Files Coverage Δ
...rch/extensions/rest/RestSendToExtensionAction.java 31.25% <ø> (ø)
...g/opensearch/index/analysis/CharFilterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/opensearch/client/indices/DataStream.java 0.00% <0.00%> (-76.09%) ⬇️
.../opensearch/client/indices/CloseIndexResponse.java 17.50% <0.00%> (-73.75%) ⬇️
.../java/org/opensearch/node/NodeClosedException.java 50.00% <0.00%> (-50.00%) ⬇️
...ava/org/opensearch/action/NoSuchNodeException.java 0.00% <0.00%> (-50.00%) ⬇️
...cluster/coordination/PendingClusterStateStats.java 20.00% <0.00%> (-48.00%) ⬇️
...opensearch/cluster/NotClusterManagerException.java 60.00% <0.00%> (-40.00%) ⬇️
...java/org/opensearch/threadpool/ThreadPoolInfo.java 56.25% <0.00%> (-37.50%) ⬇️
.../aggregations/support/values/ScriptLongValues.java 34.88% <0.00%> (-27.91%) ⬇️
... and 466 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied
Copy link
Member Author

@opensearch-project/security What do you folks think, is this a worthwhile stopgap measure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants