-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Point in time] Backport point in time changes #4406
Conversation
Signed-off-by: Bharathwaj G <[email protected]>
Signed-off-by: Bharathwaj G <[email protected]>
Signed-off-by: Bharathwaj G <[email protected]>
Signed-off-by: Bharathwaj G <[email protected]>
Signed-off-by: Bharathwaj G <[email protected]>
…vel client Signed-off-by: Bharathwaj G <[email protected]>
Signed-off-by: Bharathwaj G <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
4394ca6
to
30d854d
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Bharathwaj G <[email protected]>
30d854d
to
f808cb1
Compare
Gradle Check (Jenkins) Run Completed with:
|
/** | ||
* Create point in time for one or more indices | ||
*/ | ||
void createPit(CreatePitRequest createPITRequest, ActionListener<CreatePitResponse> listener); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bharath-techie from the API perspective, this is beaking change. Since we backport to 2.x (no breaking changes), we probably should mark this methods as default
.
@bharath-techie shouldn't we wait for #4388 before backporting? |
Gradle Check (Jenkins) Run Completed with:
|
b3b134b
to
d914b76
Compare
Signed-off-by: Ajay Kumar Movva <[email protected]>
d914b76
to
cf22f77
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #4406 +/- ##
============================================
+ Coverage 70.68% 70.70% +0.02%
- Complexity 57182 57448 +266
============================================
Files 4584 4614 +30
Lines 274497 275660 +1163
Branches 40226 40332 +106
============================================
+ Hits 194018 194908 +890
- Misses 64218 64554 +336
+ Partials 16261 16198 -63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fea49d8
to
2b793dc
Compare
2b793dc
to
80fce09
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
…ch-project#4388) * Changes for list all and pit segments Signed-off-by: Bharathwaj G <[email protected]> (cherry picked from commit bb47419)
80fce09
to
8a0b21d
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Bharathwaj G <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Description
Backport point in time changes
Issues Resolved
#1147
Original PRs
Adding create pit service layer changes #3921
Adding delete pit service layer changes #3949
Add service layer changes for list all PITs #4016
Add Point In Time Node Stats API ServiceLayer Changes #4030
Add changes to Point in time segments API service layer #4105
Add changes for Create PIT and Delete PIT rest layer and rest high level client #4064
Added RestLayer Changes for PIT stats #4217
Added rest layer changes for List all PITs and PIT segments #4388
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.