Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Point in time] Backport point in time changes #4406

Closed
wants to merge 14 commits into from

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Sep 5, 2022

Description

Backport point in time changes

Issues Resolved

#1147

Original PRs

Adding create pit service layer changes #3921
Adding delete pit service layer changes #3949
Add service layer changes for list all PITs #4016
Add Point In Time Node Stats API ServiceLayer Changes #4030
Add changes to Point in time segments API service layer #4105
Add changes for Create PIT and Delete PIT rest layer and rest high level client #4064
Added RestLayer Changes for PIT stats #4217
Added rest layer changes for List all PITs and PIT segments #4388

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bharath-techie bharath-techie requested review from a team and reta as code owners September 5, 2022 11:06
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Bharathwaj G <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Gradle Check (Jenkins) Run Completed with:

/**
* Create point in time for one or more indices
*/
void createPit(CreatePitRequest createPITRequest, ActionListener<CreatePitResponse> listener);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharath-techie from the API perspective, this is beaking change. Since we backport to 2.x (no breaking changes), we probably should mark this methods as default.

@reta
Copy link
Collaborator

reta commented Sep 6, 2022

@bharath-techie shouldn't we wait for #4388 before backporting?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4406 (cf22f77) into 2.x (fc97324) will increase coverage by 0.02%.
The diff coverage is 73.89%.

@@             Coverage Diff              @@
##                2.x    #4406      +/-   ##
============================================
+ Coverage     70.68%   70.70%   +0.02%     
- Complexity    57182    57448     +266     
============================================
  Files          4584     4614      +30     
  Lines        274497   275660    +1163     
  Branches      40226    40332     +106     
============================================
+ Hits         194018   194908     +890     
- Misses        64218    64554     +336     
+ Partials      16261    16198      -63     
Impacted Files Coverage Δ
...ava/org/opensearch/client/RestHighLevelClient.java 42.40% <0.00%> (-1.62%) ⬇️
...er/src/main/java/org/opensearch/client/Client.java 40.00% <ø> (ø)
.../org/opensearch/client/support/AbstractClient.java 34.43% <0.00%> (-0.79%) ⬇️
...rg/opensearch/common/settings/ClusterSettings.java 91.89% <ø> (ø)
...c/main/java/org/opensearch/index/IndexService.java 74.48% <0.00%> (+0.45%) ⬆️
...rg/opensearch/action/search/CreatePitResponse.java 15.15% <15.15%> (ø)
...pensearch/action/search/GetAllPitNodesRequest.java 33.33% <33.33%> (ø)
...ensearch/action/search/GetAllPitNodesResponse.java 36.00% <36.00%> (ø)
...pensearch/action/search/GetAllPitNodeResponse.java 47.61% <47.61%> (ø)
...java/org/opensearch/action/search/SearchUtils.java 50.00% <50.00%> (ø)
... and 560 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bharath-techie bharath-techie force-pushed the pits2.x branch 2 times, most recently from fea49d8 to 2b793dc Compare September 27, 2022 05:28
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

…ch-project#4388)

* Changes for list all and pit segments

Signed-off-by: Bharathwaj G <[email protected]>
(cherry picked from commit bb47419)
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Bharathwaj G <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants