-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Set analyzer to regex query string search #4219
Conversation
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
manual intervention needed
the weird thing is that @yyyogev signed all his commits with his personal email address. but when the merge commit was performed by maintainers the email was changed somehow to his work email. this is unfortunate. @nknize - what logic get's the email for the commit to |
The first commit was signed off using his work email address. For the final commit message I manually deleted all of the cruft leading up to that first commit message that concisely describes the change (no need to dirty the final commit log with all of the squashed commit messages like "small change"). Since that first message was signed off w/ the work email address it made the final message. I've had these issues before as well (e.g., my gmail vs apache email address). The reason it does this is because of the way the DCO sign-off validates the email address, it's not smart enough to check all of the email addresses verified on a contributor's github profile. It's a PITA, honestly, and should be improved. I can fix DCO here shortly (unless another maintainer wants to take care of it). |
thanks, @nknize for the clear explanation. I missed that first commit somehow. |
Sets analyzer to regex query string search Signed-off-by: yogev mets <[email protected]> (cherry picked from commit ea4cfcc)
d7b8abf
to
d675e6b
Compare
Signed-off-by: Nicholas Walter Knize <[email protected]>
Apologies.. this dropped off my plate. Rebased, updated changelog, and fixed DCO sign-off. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #4219 +/- ##
============================================
+ Coverage 70.62% 70.65% +0.03%
- Complexity 57126 57453 +327
============================================
Files 4585 4615 +30
Lines 274526 275873 +1347
Branches 40233 40366 +133
============================================
+ Hits 193876 194920 +1044
- Misses 64403 64675 +272
- Partials 16247 16278 +31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This feature was backported in opensearch-project#4219 and will only be present in version 2.4 and newer. The test must be skipped for mixed cluster cases with nodes older than 2.4. Signed-off-by: Andrew Ross <[email protected]>
This feature was backported in opensearch-project#4219 and will only be present in version 2.4 and newer. The test must be skipped for mixed cluster cases with nodes older than 2.4. Signed-off-by: Andrew Ross <[email protected]>
This feature was backported in #4219 and will only be present in version 2.4 and newer. The test must be skipped for mixed cluster cases with nodes older than 2.4. Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: Andrew Ross <[email protected]>
Backport ea4cfcc from #3967