Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Set analyzer to regex query string search #4219

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ea4cfcc from #3967

@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners August 15, 2022 23:36
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual intervention needed

@AmiStrn
Copy link
Contributor

AmiStrn commented Sep 6, 2022

the weird thing is that @yyyogev signed all his commits with his personal email address. but when the merge commit was performed by maintainers the email was changed somehow to his work email. this is unfortunate.
I asked @yyyogev to open backports for this.

@nknize - what logic get's the email for the commit to main?

@nknize
Copy link
Collaborator

nknize commented Sep 6, 2022

what logic get's the email for the commit to main?

The first commit was signed off using his work email address. For the final commit message I manually deleted all of the cruft leading up to that first commit message that concisely describes the change (no need to dirty the final commit log with all of the squashed commit messages like "small change"). Since that first message was signed off w/ the work email address it made the final message. I've had these issues before as well (e.g., my gmail vs apache email address). The reason it does this is because of the way the DCO sign-off validates the email address, it's not smart enough to check all of the email addresses verified on a contributor's github profile. It's a PITA, honestly, and should be improved.

I can fix DCO here shortly (unless another maintainer wants to take care of it).

@AmiStrn
Copy link
Contributor

AmiStrn commented Sep 7, 2022

thanks, @nknize for the clear explanation. I missed that first commit somehow.

Sets analyzer to regex query string search

Signed-off-by: yogev mets <[email protected]>
(cherry picked from commit ea4cfcc)
@nknize nknize force-pushed the backport/backport-3967-to-2.x branch from d7b8abf to d675e6b Compare October 12, 2022 21:51
Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize
Copy link
Collaborator

nknize commented Oct 12, 2022

Apologies.. this dropped off my plate. Rebased, updated changelog, and fixed DCO sign-off.

@nknize nknize added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 12, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4219 (e6d6205) into 2.x (a90fd73) will increase coverage by 0.03%.
The diff coverage is 65.40%.

@@             Coverage Diff              @@
##                2.x    #4219      +/-   ##
============================================
+ Coverage     70.62%   70.65%   +0.03%     
- Complexity    57126    57453     +327     
============================================
  Files          4585     4615      +30     
  Lines        274526   275873    +1347     
  Branches      40233    40366     +133     
============================================
+ Hits         193876   194920    +1044     
- Misses        64403    64675     +272     
- Partials      16247    16278      +31     
Impacted Files Coverage Δ
...main/java/org/opensearch/gradle/PublishPlugin.java 43.43% <0.00%> (-0.45%) ⬇️
...ava/org/opensearch/client/RestHighLevelClient.java 41.75% <0.00%> (-2.27%) ⬇️
...er/src/main/java/org/opensearch/client/Client.java 40.00% <ø> (ø)
.../org/opensearch/client/support/AbstractClient.java 34.25% <0.00%> (-0.45%) ⬇️
...main/java/org/opensearch/common/lucene/Lucene.java 68.57% <ø> (+2.76%) ⬆️
...rg/opensearch/common/settings/ClusterSettings.java 91.89% <ø> (ø)
...pensearch/common/settings/IndexScopedSettings.java 100.00% <ø> (ø)
...index/codec/PerFieldMappingPostingFormatCodec.java 64.28% <ø> (ø)
...rg/opensearch/index/engine/TranslogLeafReader.java 40.90% <ø> (ø)
...java/org/opensearch/index/get/ShardGetService.java 60.89% <ø> (ø)
... and 556 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nknize nknize merged commit 9968840 into 2.x Oct 13, 2022
andrross added a commit to andrross/OpenSearch that referenced this pull request Oct 21, 2022
This feature was backported in opensearch-project#4219 and will only be present in
version 2.4 and newer. The test must be skipped for mixed cluster cases
with nodes older than 2.4.

Signed-off-by: Andrew Ross <[email protected]>
andrross added a commit to andrross/OpenSearch that referenced this pull request Oct 21, 2022
This feature was backported in opensearch-project#4219 and will only be present in
version 2.4 and newer. The test must be skipped for mixed cluster cases
with nodes older than 2.4.

Signed-off-by: Andrew Ross <[email protected]>
andrross added a commit that referenced this pull request Oct 21, 2022
This feature was backported in #4219 and will only be present in
version 2.4 and newer. The test must be skipped for mixed cluster cases
with nodes older than 2.4.

Signed-off-by: Andrew Ross <[email protected]>

Signed-off-by: Andrew Ross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments enhancement Enhancement or improvement to existing feature or request v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants