Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Deprecate and rename abstract methods in interfaces that contain 'master' in name #4122

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Aug 4, 2022

Backport ba9cdcd from #4121

Deprecate and rename abstract methods in interface

- in interface LocalNodeMasterListener:
void onMaster()
void offMaster()
- in interface AckedRequest:
TimeValue masterNodeTimeout()

…ter' in name (#4121)

Signed-off-by: Xue Zhou <[email protected]>
(cherry picked from commit ba9cdcd)
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners August 4, 2022 01:20
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Gradle Check (Jenkins) Run Completed with:

@tlfeng
Copy link
Collaborator

tlfeng commented Aug 4, 2022

In build 1416:

> Task :plugins:repository-s3:yamlRestTest

REPRODUCE WITH: ./gradlew ':plugins:repository-s3:yamlRestTest' --tests "org.opensearch.repositories.s3.RepositoryS3ClientYamlTestSuiteIT.test {yaml=repository_s3/20_repository_permanent_credentials/Snapshot and Restore with repository-s3 using permanent credentials}" -Dtests.seed=D2A4C945B309FD46 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-LB -Dtests.timezone=Africa/Dakar -Druntime.java=17 -Dtests.rest.denylist=repository_s3/30_repository_temporary_credentials/*,repository_s3/40_repository_ec2_credentials/*,repository_s3/50_repository_ecs_credentials/*,repository_s3/60_repository_eks_credentials/*

org.opensearch.repositories.s3.RepositoryS3ClientYamlTestSuiteIT > test {yaml=repository_s3/20_repository_permanent_credentials/Snapshot and Restore with repository-s3 using permanent credentials} FAILED
    java.lang.AssertionError: Failure at [repository_s3/20_repository_permanent_credentials:244]: expected [2xx] status code but api [snapshot.restore] returned [404 Not Found] [{"error":{"root_cause":[{"type":"snapshot_missing_exception","reason":"[repository_permanent:snapshot-one/8mXh1LBqTjSq-uZOhcgV4Q] is missing","stack_trace":"SnapshotMissingException[[repository_permanent:snapshot-one/8mXh1LBqTjSq-uZOhcgV4Q] is missing]; nested: NoSuchFileException[Blob object [****_integration_tests/snap-8mXh1LBqTjSq-uZOhcgV4Q.dat] not found: The specified key does not exist. (Service: Amazon S3; Status Code: 404; Error Code: NoSuchKey; Request ID: HAZNQYZ4400KNKKC; S3 Extended Request ID: Lghc26ALGZhmkwujL6PLA/xP9N9eoizpyqOOJodxe/xpnruMtTJomktTx+QxrjmbX7nF/iNghUM=; Proxy: null)];
org.opensearch.repositories.blobstore.BlobStoreRepository.getSnapshotInfo(BlobStoreRepository.java:1505)\n\tat org.opensearch.snapshots.RestoreService.lambda$restoreSnapshot$2(RestoreService.java:231)\n\tat 
...

Added to issue #2064 (comment)

@tlfeng tlfeng added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments deprecate v2.3.0 'Issues and PRs related to version v2.3.0' labels Aug 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4122 (6cc2d79) into 2.x (1a15a79) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##                2.x    #4122      +/-   ##
============================================
- Coverage     70.59%   70.55%   -0.05%     
+ Complexity    56712    56659      -53     
============================================
  Files          4553     4555       +2     
  Lines        272770   272776       +6     
  Branches      40049    40049              
============================================
- Hits         192573   192464     -109     
- Misses        64001    64161     +160     
+ Partials      16196    16151      -45     
Impacted Files Coverage Δ
.../java/org/opensearch/cluster/ack/AckedRequest.java 0.00% <0.00%> (ø)
...earch/cluster/LocalNodeClusterManagerListener.java 71.42% <100.00%> (ø)
...rg/opensearch/cluster/LocalNodeMasterListener.java 100.00% <100.00%> (ø)
...pensearch/client/cluster/RemoteConnectionInfo.java 0.00% <0.00%> (-75.00%) ⬇️
...a/org/opensearch/client/cluster/SniffModeInfo.java 0.00% <0.00%> (-62.50%) ⬇️
...a/org/opensearch/client/cluster/ProxyModeInfo.java 0.00% <0.00%> (-57.90%) ⬇️
...cluster/coordination/PendingClusterStateStats.java 20.00% <0.00%> (-48.00%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-44.45%) ⬇️
.../opensearch/client/cluster/RemoteInfoResponse.java 61.53% <0.00%> (-38.47%) ⬇️
...cluster/coordination/PublishClusterStateStats.java 33.33% <0.00%> (-37.51%) ⬇️
... and 464 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xuezhou25 xuezhou25 merged commit cfda17d into 2.x Aug 4, 2022
@github-actions github-actions bot deleted the backport/backport-4121-to-2.x branch August 4, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments deprecate enhancement Enhancement or improvement to existing feature or request v2.3.0 'Issues and PRs related to version v2.3.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants