[Backport 2.x] [Segment Replication] Add a new Engine implementation for replicas with segment replication enabled. #4003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion for newChangesSnapshotFromTranslogFile() in NRTReplicationEngine Signed-off-by: Rishikesh1159 <[email protected]>
Rishikesh1159
commented
Jul 25, 2022
|
|
||
| @Deprecated | ||
| @Override | ||
| public Translog.Snapshot newChangesSnapshotFromTranslogFile(String source, long fromSeqNo, long toSeqNo, boolean requiredFullRange) |
There was a problem hiding this comment.
@mch2 I added this implementation temporarily, let me know if this is good or you just want to return null or entirely remove this method from Engine as it will be deprecated
There was a problem hiding this comment.
Removing the method is a breaking change. We can't introduce that in a backport. I would suggest we use the same impl as InternalEngine here.
public Translog.Snapshot newChangesSnapshotFromTranslogFile(String source, long fromSeqNo, long toSeqNo, boolean requiredFullRange)
throws IOException {
return getTranslog().newSnapshot(fromSeqNo, toSeqNo, requiredFullRange);
}
Bukhtawar
reviewed
Jul 25, 2022
Comment on lines
172
to
177
| /** | ||
| * Return the latest active SegmentInfos from the engine. | ||
| * @return {@link SegmentInfos} | ||
| */ | ||
| protected abstract SegmentInfos getLatestSegmentInfos(); | ||
|
|
There was a problem hiding this comment.
Isn't this a breaking change for 2.x?
There was a problem hiding this comment.
Good call @Rishikesh1159 We'll need to provide default impl here and remove abstract.
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #4003 +/- ##
============================================
- Coverage 70.63% 70.53% -0.10%
- Complexity 56487 56514 +27
============================================
Files 4527 4532 +5
Lines 271798 272037 +239
Branches 39975 39987 +12
============================================
- Hits 191985 191887 -98
- Misses 63718 64036 +318
- Partials 16095 16114 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. |
…ava and adressing comments from previous PR Signed-off-by: Rishikesh1159 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
dreamer-89
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rishikesh1159 [email protected]
Description
This PR backports PR to 2.x branch and resolve conflict in LocalCheckpointTrackerTests, LocalCheckpointTracker classes.
Issues Resolved
#3109
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.