Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing Java docs for new Translog implementation #3936

Merged

Conversation

saratvemulapalli
Copy link
Member

@saratvemulapalli saratvemulapalli commented Jul 18, 2022

Signed-off-by: Sarat Vemulapalli [email protected]

Description

Missing Java docs is causing failures on my local builds.
Was trying to debug: #3935 (comment)

Seeing failures: Not sure why CI is not seeing this problem. Will take it as a follow up.

./gradlew ':server:test' --tests "org.opensearch.common.time.DateUtilsTests.testTimezoneIds" 

> Configure project :qa:os
Cannot add task 'destructiveDistroTest.docker' as a task with that name already exists.
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.5
  OS Info               : Linux 5.4.0-1037-aws (amd64)
  JDK Version           : 14 (Private Build JDK)
  JAVA_HOME             : /usr/lib/jvm/java-14-openjdk-amd64
  Random Testing Seed   : BB94918BD913A13B
  In FIPS 140 mode      : false
=======================================

> Task :server:compileJava
/home/ubuntu/joda-opensearch/server/src/main/java/org/opensearch/index/translog/TranslogManager.java:101: warning: no description for @throws
     * @throws IOException
       ^
/home/ubuntu/joda-opensearch/server/src/main/java/org/opensearch/index/translog/TranslogManager.java:107: warning: no description for @param
     * @param operation
       ^
/home/ubuntu/joda-opensearch/server/src/main/java/org/opensearch/index/translog/TranslogManager.java:109: warning: no description for @throws
     * @throws IOException
       ^
/home/ubuntu/joda-opensearch/server/src/main/java/org/opensearch/index/translog/InternalTranslogManager.java:288: warning: no description for @param
     * @param location
       ^
/home/ubuntu/joda-opensearch/server/src/main/java/org/opensearch/index/translog/InternalTranslogManager.java:290: warning: no description for @throws
     * @throws IOException
       ^
/home/ubuntu/joda-opensearch/server/src/main/java/org/opensearch/index/translog/InternalTranslogManager.java:299: warning: no description for @param
     * @param operation
       ^
/home/ubuntu/joda-opensearch/server/src/main/java/org/opensearch/index/translog/InternalTranslogManager.java:301: warning: no description for @throws
     * @throws IOException
       ^
/home/ubuntu/joda-opensearch/server/src/main/java/org/opensearch/index/translog/InternalTranslogManager.java:399: warning: no description for @param
     * @param localCheckpointOfLastCommit
       ^
/home/ubuntu/joda-opensearch/server/src/main/java/org/opensearch/index/translog/InternalTranslogManager.java:400: warning: no description for @param
     * @param flushThreshold
       ^
error: warnings found and -Werror specified
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
9 warnings

> Task :server:compileJava FAILED

FAILURE: Build failed with an exception.

Issues Resolved

Closes #3892

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saratvemulapalli saratvemulapalli requested review from a team and reta as code owners July 18, 2022 18:49
@saratvemulapalli saratvemulapalli added the documentation Improvements or additions to documentation label Jul 18, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@saratvemulapalli
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

#3872

@tlfeng
Copy link
Collaborator

tlfeng commented Jul 18, 2022

Thank you @saratvemulapalli for adding the missing javadoc, and there is an open issue: #3892 😁

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @saratvemulapalli!

@saratvemulapalli
Copy link
Member Author

Thank you @saratvemulapalli for adding the missing javadoc, and there is an open issue: #3892 😁

Lol I didnt know an issue existed. Thanks @tlfeng !

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@saratvemulapalli saratvemulapalli merged commit 07775ff into opensearch-project:main Jul 18, 2022
@saratvemulapalli saratvemulapalli deleted the translog-java-docs branch July 18, 2022 21:31
@andrross andrross added the backport 2.x Backport to 2.x branch label Jan 24, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 24, 2023
Signed-off-by: Sarat Vemulapalli <[email protected]>
(cherry picked from commit 07775ff)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Jan 24, 2023
Signed-off-by: Sarat Vemulapalli <[email protected]>
(cherry picked from commit 07775ff)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch documentation Improvements or additions to documentation
Projects
Status: Planned work items
Development

Successfully merging this pull request may close these issues.

[BUG] gradlew run returns error error: warnings found and -Werror specified
6 participants