Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov status badge #3845

Closed

Conversation

dreamer-89
Copy link
Member

Description

Add readme code cov status badge

Issues Resolved

#1323

Related

#850

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89 dreamer-89 requested review from a team and reta as code owners July 11, 2022 16:41
Signed-off-by: Suraj Singh <[email protected]>
@dreamer-89 dreamer-89 force-pushed the add_codecov_status_badge branch from 5f5d965 to 61be6c5 Compare July 11, 2022 16:42
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Hi @dreamer-89 the badge placement needs to be tweaked.

Thanks.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member Author

dreamer-89 commented Jul 11, 2022

image

Hi @dreamer-89 the badge placement needs to be tweaked.

Thanks.

Thanks @peterzhuamazon for pointing this out. Added a newline to segregate badge and logo.

Screen Shot 2022-07-11 at 1 04 51 PM

@peterzhuamazon peterzhuamazon added backport 1.x backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch backport 1.3 Backport to 1.3 branch backport 2.1 labels Jul 11, 2022
@peterzhuamazon
Copy link
Member

Since I setup each branch have its own coverage I think we can backport this.
Tho @dreamer-89 you might want to change each backport to have different links.

Example 1.x: https://app.codecov.io/gh/opensearch-project/opensearch/branch/1.x

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member Author

dreamer-89 commented Jul 11, 2022

Looks like there was already a PR out for adding readme badge. Let's not merge this one and close the other one. Converted to draft, will close once below PR is merged.
#1596

@dreamer-89
Copy link
Member Author

Since I setup each branch have its own coverage I think we can backport this. Tho @dreamer-89 you might want to change each backport to have different links.

Example 1.x: https://app.codecov.io/gh/opensearch-project/opensearch/branch/1.x

That's a good point. We should have branch specific links.

Though, I am thinking if there is a more generic fix which handles future branches as well.

@dreamer-89 dreamer-89 marked this pull request as draft July 11, 2022 20:57
@dblock
Copy link
Member

dblock commented Jul 11, 2022

Dup of #1596? Can we close?

@dreamer-89
Copy link
Member Author

Closed in favour of

Dup of #1596? Can we close?

Closed

@dreamer-89 dreamer-89 closed this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x backport 1.3 Backport to 1.3 branch backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch backport 2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants