Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 7.5 #3594

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Update to Gradle 7.5 #3594

merged 1 commit into from
Jul 14, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Jun 15, 2022

Signed-off-by: Andriy Redko [email protected]

Description

Gradle 7.5 update. As always, hitting API incompatibilities.

Issues Resolved

Closes #3901

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 395aeee7b353130a95c3af658d8300143fdd5b1e
Log 6040

Reports 6040

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 387c396c4e55cb29779dfb163da195deb48888b9
Log 6041

Reports 6041

@reta
Copy link
Collaborator Author

reta commented Jun 15, 2022

start gradle check`

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 387c396c4e55cb29779dfb163da195deb48888b9
Log 6045

Reports 6045

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success bff8ec47369570e98570374785bfe5a82d71542a
Log 6058

Reports 6058

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 18a87bc9829077b0dcdb22d1969b51f197e4874e
Log 6061

Reports 6061

@reta
Copy link
Collaborator Author

reta commented Jun 16, 2022

x Gradle Check failure 18a87bc Log 6061

Reports 6061

@imRishN @Bukhtawar we have a new flaky tests after #3563, here is the failure:

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness" -Dtests.seed=CD3B9289D31206B8 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=nl -Dtests.timezone=Asia/Katmandu -Druntime.java=17

org.opensearch.cluster.allocation.AwarenessAllocationIT > testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness FAILED
    java.lang.AssertionError: unexpected
        at org.opensearch.test.InternalTestCluster.removeExclusions(InternalTestCluster.java:1912)
        at org.opensearch.test.InternalTestCluster.stopNodesAndClients(InternalTestCluster.java:1777)
        at org.opensearch.test.InternalTestCluster.stopNodesAndClient(InternalTestCluster.java:1764)
        at org.opensearch.test.InternalTestCluster.stopRandomNode(InternalTestCluster.java:1672)
        at org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness(AwarenessAllocationIT.java:425)

        Caused by:
        java.util.concurrent.ExecutionException: MasterNotDiscoveredException[null]
            at org.opensearch.common.util.concurrent.BaseFuture$Sync.getValue(BaseFuture.java:286)
            at org.opensearch.common.util.concurrent.BaseFuture$Sync.get(BaseFuture.java:273)
            at org.opensearch.common.util.concurrent.BaseFuture.get(BaseFuture.java:104)
            at org.opensearch.test.InternalTestCluster.removeExclusions(InternalTestCluster.java:1910)
            ... 4 more

            Caused by:
            MasterNotDiscoveredException[null]
                at app//org.opensearch.action.support.clustermanager.TransportClusterManagerNodeAction$AsyncSingleAction$2.onTimeout(TransportClusterManagerNodeAction.java:282)
                at app//org.opensearch.cluster.ClusterStateObserver$ContextPreservingListener.onTimeout(ClusterStateObserver.java:394)
                at app//org.opensearch.cluster.ClusterStateObserver$ObserverClusterStateListener.onTimeout(ClusterStateObserver.java:294)
                at app//org.opensearch.cluster.service.ClusterApplierService$NotifyTimeout.run(ClusterApplierService.java:697)
                at app//org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:739)
                at [email protected]/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
                at [email protected]/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
                at [email protected]/java.lang.Thread.run(Thread.java:833)

    MasterNotDiscoveredException[null]
        at app//org.opensearch.action.support.clustermanager.TransportClusterManagerNodeAction$AsyncSingleAction$2.onTimeout(TransportClusterManagerNodeAction.java:282)
        at app//org.opensearch.cluster.ClusterStateObserver$ContextPreservingListener.onTimeout(ClusterStateObserver.java:394)
        at app//org.opensearch.cluster.ClusterStateObserver$ObserverClusterStateListener.onTimeout(ClusterStateObserver.java:294)
        at app//org.opensearch.cluster.service.ClusterApplierService$NotifyTimeout.run(ClusterApplierService.java:697)
        at app//org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:739)
        at [email protected]/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at [email protected]/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at [email protected]/java.lang.Thread.run(Thread.java:833)

Created #3603

@reta
Copy link
Collaborator Author

reta commented Jun 16, 2022

start gradle check

1 similar comment
@reta
Copy link
Collaborator Author

reta commented Jun 16, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 18a87bc9829077b0dcdb22d1969b51f197e4874e
Log 6064

Reports 6064

@reta
Copy link
Collaborator Author

reta commented Jun 16, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 18a87bc9829077b0dcdb22d1969b51f197e4874e
Log 6065

Reports 6065

@reta
Copy link
Collaborator Author

reta commented Jun 16, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 18a87bc9829077b0dcdb22d1969b51f197e4874e
Log 6066

Reports 6066

@reta
Copy link
Collaborator Author

reta commented Jun 16, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 18a87bc9829077b0dcdb22d1969b51f197e4874e
Log 6067

Reports 6067

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta marked this pull request as ready for review July 14, 2022 13:58
@reta reta requested a review from a team as a code owner July 14, 2022 13:58
Signed-off-by: Andriy Redko <[email protected]>
@reta reta changed the title [WIP] Update to Gradle 7.5 Update to Gradle 7.5 Jul 14, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta added the backport 2.x Backport to 2.x branch label Jul 14, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugins will have to upgrade too I imagine?

@dblock dblock merged commit d4465ce into opensearch-project:main Jul 14, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 14, 2022
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit d4465ce)
@reta
Copy link
Collaborator Author

reta commented Jul 14, 2022

Plugins will have to upgrade too I imagine?

Yes, desirable (but luckily it is non breaking), I will take plugins + java client one by one

dblock pushed a commit that referenced this pull request Jul 14, 2022
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit d4465ce)

Co-authored-by: Andriy Redko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Gradle 7.5
5 participants