Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'whitelist' terminology in Java API #3350

Merged

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented May 17, 2022

Description

Replace 'whitelist' terminology in Java API and Gradle project name.
Replacement rule: whitelist -> allowlist
This is a breaking change that will impact other programs using OpenSearch Java library.

Issues Resolved

Resolve #1683

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@tlfeng tlfeng added >breaking Identifies a breaking change. v3.0.0 Issues and PRs related to version 3.0.0 labels May 17, 2022
@tlfeng tlfeng requested review from a team and reta as code owners May 17, 2022 04:20
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 581865bc4703120bf9cdae98a7722ff616b5c4e0
Log 5391

Reports 5391

@tlfeng tlfeng force-pushed the blackwhitelist-java-api branch from 581865b to 77f7d72 Compare May 17, 2022 05:08
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 77f7d72
Log 5395

Reports 5395

@saratvemulapalli
Copy link
Member

@tlfeng is the change intended to go in 3.0.0 and not 2.0?

@tlfeng
Copy link
Collaborator Author

tlfeng commented May 17, 2022

@nknize Thanks a lot for your review!
@saratvemulapalli Yes, it's target for version 3.0, I wanted to give the other developers more time to adapt the terminology change. These changes are public Java API which are packaged in jar file and published to Maven, ideally I should add @deprecate annotation first, but they are too many methods or classes to be deprecated, so I decided to rename them directly in next major version.

@saratvemulapalli
Copy link
Member

Added this PR to the list: #3351

@saratvemulapalli saratvemulapalli merged commit 8f8909f into opensearch-project:main May 17, 2022
@tlfeng tlfeng deleted the blackwhitelist-java-api branch May 20, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking Identifies a breaking change. v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "blacklist/whitelist" terminology in Java APIs
4 participants