-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: do not ship jdk when no-jdk option set #3039
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Gradle Check failure e503ab41d68294d1c0851545f95388ddbd6a1042 |
Gradle check look to fail since #2924 so don't think its related to this change |
Let's rebase over #3042 once that's merged. |
When using package distribution ``` ./gradlew :distribution:packages:no-jdk-deb:assemble ``` When `true` this include jdk switch the boolean to the correct value fix opensearch-project#3024 Signed-off-by: Laurent Arnoud <[email protected]>
|
start gradle check |
@dblock yay all green! |
dblock
approved these changes
Apr 28, 2022
reta
approved these changes
Apr 29, 2022
nknize
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using package distribution
When
true
this include jdk switch the boolean to the correct valueIssues Resolved
fix #3024
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.