Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: do not ship jdk when no-jdk option set #3039

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

spk
Copy link
Contributor

@spk spk commented Apr 22, 2022

Description

When using package distribution

./gradlew :distribution:packages:no-jdk-deb:assemble

When true this include jdk switch the boolean to the correct value

Issues Resolved

fix #3024

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@spk spk requested review from a team and reta as code owners April 22, 2022 07:48
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure e503ab41d68294d1c0851545f95388ddbd6a1042
Log 4711

Reports 4711

@spk
Copy link
Contributor Author

spk commented Apr 22, 2022

Gradle check look to fail since #2924 so don't think its related to this change

@dblock
Copy link
Member

dblock commented Apr 22, 2022

Let's rebase over #3042 once that's merged.

When using package distribution

```
./gradlew :distribution:packages:no-jdk-deb:assemble
```

When `true` this include jdk switch the boolean to the correct value

fix opensearch-project#3024

Signed-off-by: Laurent Arnoud <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 17cf2a5
Log 4849

Reports 4849

@spk
Copy link
Contributor Author

spk commented Apr 28, 2022

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([C65F074C70047C63:C129D2874B820A3E]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/home/ubuntu/.gradle/wrapper/dists/gradle-7.4.2-all/9uukhhbclvbegdvsww0j0cr3p/gradle-7.4.2/lib/plugins/gradle-testing-base-7.4.2.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

@spk
Copy link
Contributor Author

spk commented Apr 28, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 17cf2a5
Log 4850

Reports 4850

@spk
Copy link
Contributor Author

spk commented Apr 28, 2022

@dblock yay all green!

@dblock dblock merged commit 8a19ccc into opensearch-project:main Apr 29, 2022
@spk spk deleted the build-no-jdk-fix branch May 2, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] release build with no-jdk still ship the jdk15
5 participants